Fix error in non-feature specs under certain conditions

This fixes #1028 [1].

[1] #1028

Author: badeball

CHANGELOG.md

@@ -6,6 +6,8 @@ All notable changes to this project will be documented in this file.
 
 - Step hooks are logged using separate log groups, similar to how scenario hooks are logged.
 
+- Fix error in non-feature specs under certain conditions, fixes [#1028](https://github.com/badeball/cypress-cucumber-preprocessor/issues/1028).
+
 ## v17.2.0
 
 - Add BeforeStep and AfterStep hooks, fixes [#847](https://github.com/badeball/cypress-cucumber-preprocessor/issues/847).

features/issues/1017.feature

@@ -2,7 +2,7 @@
 
 @network
 Feature: JSON report
-  Scenario: with after hook
+  Scenario: with after hook and reload-behavior
     Given additional preprocessor configuration
       """
       {

features/issues/1028.feature

@@ -0,0 +1,29 @@
+# https://github.com/badeball/cypress-cucumber-preprocessor/issues/1028
+
+@network
+Feature: non-feature specs
+  Scenario: with messages enabled + reload-behavior
+    Given additional preprocessor configuration
+      """
+      {
+        "messages": {
+          "enabled": true
+        }
+      }
+      """
+    And additional Cypress configuration
+      """
+      {
+        "e2e": {
+          "specPattern": "**/spec.js"
+        }
+      }
+      """
+    And a file named "cypress/e2e/spec.js" with:
+      """
+      it("should work", () => {
+        cy.visit("https://duckduckgo.com/")
+      })
+      """
+    When I run cypress
+    Then it passes

lib/add-cucumber-preprocessor-plugin.ts

@@ -95,7 +95,7 @@ export default async function addCucumberPreprocessorPlugin(
   }
 
   if (!options.omitBeforeSpecHandler) {
-    on("before:spec", () => beforeSpecHandler(config));
+    on("before:spec", (spec) => beforeSpecHandler(config, spec));
   }
 
   if (!options.omitAfterSpecHandler) {

lib/plugin-event-handlers.ts

@@ -98,6 +98,8 @@ let state: State = {
   state: "initial",
 };
 
+const isFeature = (spec: Cypress.Spec) => spec.name.endsWith(".feature");
+
 export async function beforeRunHandler(config: Cypress.PluginConfigOptions) {
   debug("beforeRunHandler()");
 
@@ -281,10 +283,13 @@ export async function afterRunHandler(config: Cypress.PluginConfigOptions) {
   }
 }
 
-export async function beforeSpecHandler(config: Cypress.PluginConfigOptions) {
+export async function beforeSpecHandler(
+  config: Cypress.PluginConfigOptions,
+  spec: Cypress.Spec
+) {
   debug("beforeSpecHandler()");
 
-  if (!config.isTextTerminal) {
+  if (!config.isTextTerminal || !isFeature(spec)) {
     return;
   }
 
@@ -320,7 +325,7 @@ export async function afterSpecHandler(
 ) {
   debug("afterSpecHandler()");
 
-  if (!config.isTextTerminal) {
+  if (!config.isTextTerminal || !isFeature(spec)) {
     return;
   }