Fix CI

Of course, it's always the multi-billion corporation MSVC compiler, while GCC and Clang are working like a charm.

Author: baderouaich

src/Core/Constants.hpp

@@ -19,7 +19,7 @@ namespace Enigma::Constants {
     // https://i.stack.imgur.com/0hNsK.jpg
 
     static constexpr std::size_t MINIMUM_PASSWORD_LENGTH = 6; // AT LEAST 6 CHARACTERS, FOR SECURITY REASONS.
-    static constexpr char *SPECIAL_CHARACTERS = R"(!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~)";
+    static constexpr char SPECIAL_CHARACTERS[] = R"(!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~)";
 
     namespace AES {
       //https://www.cryptopp.com/wiki/GCM_Mode
@@ -88,7 +88,7 @@ namespace Enigma::Constants {
 #endif
 
   namespace CLI {
-    static constexpr char *CLI_HELP_MESSAGE = "Say -h or --help to display available options";
+    static constexpr char CLI_HELP_MESSAGE[] = "Say -h or --help to display available options";
   }
 
   namespace Links {

src/Meta/Endianness.hpp

@@ -15,7 +15,7 @@
 
 namespace Enigma {
 
-  constexpr std::uint64_t BSwap64(std::uint64_t host_int) {
+  inline std::uint64_t BSwap64(std::uint64_t host_int) {
 #if defined(__GNUC__) || ENIGMA_HAVE_BUILTIN(__builtin_bswap64)
     return __builtin_bswap64(host_int);
 #elif defined(_MSC_VER)
@@ -32,7 +32,7 @@ namespace Enigma {
 #endif
   }
 
-  constexpr std::uint32_t BSwap32(std::uint32_t host_int) {
+  inline std::uint32_t BSwap32(std::uint32_t host_int) {
 #if defined(__GNUC__) || ENIGMA_HAVE_BUILTIN(__builtin_bswap32)
     return __builtin_bswap32(host_int);
 #elif defined(_MSC_VER)
@@ -45,7 +45,7 @@ namespace Enigma {
 #endif
   }
 
-  constexpr std::uint16_t BSwap16(std::uint16_t host_int) {
+  inline std::uint16_t BSwap16(std::uint16_t host_int) {
 #if defined(__GNUC__) || ENIGMA_HAVE_BUILTIN(__builtin_bswap16)
     return __builtin_bswap16(host_int);
 #elif defined(_MSC_VER)
@@ -58,48 +58,48 @@ namespace Enigma {
 
   namespace LittleEndian {
 
-    constexpr std::uint16_t fromHost(std::uint16_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint16_t fromHost(std::uint16_t value) {
+      if (std::endian::native == std::endian::big) {
         return BSwap16(value);
       } else {
         return value;
       }
     }
 
-    constexpr std::uint32_t fromHost(std::uint32_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint32_t fromHost(std::uint32_t value) {
+      if (std::endian::native == std::endian::big) {
         return BSwap32(value);
       } else {
         return value;
       }
     }
 
-    constexpr std::uint64_t fromHost(std::uint64_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint64_t fromHost(std::uint64_t value) {
+      if (std::endian::native == std::endian::big) {
         return BSwap64(value);
       } else {
         return value;
       }
     }
 
-    constexpr std::uint16_t toHost(std::uint16_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint16_t toHost(std::uint16_t value) {
+      if (std::endian::native == std::endian::big) {
         return BSwap16(value);
       } else {
         return value;
       }
     }
 
-    constexpr std::uint32_t toHost(std::uint32_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint32_t toHost(std::uint32_t value) {
+      if (std::endian::native == std::endian::big) {
         return BSwap32(value);
       } else {
         return value;
       }
     }
 
-    constexpr std::uint64_t toHost(std::uint64_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint64_t toHost(std::uint64_t value) {
+      if (std::endian::native == std::endian::big) {
         return BSwap64(value);
       } else {
         return value;
@@ -110,48 +110,48 @@ namespace Enigma {
 
   //[[maybe_unused]]
   namespace BigEndian {
-    constexpr std::uint16_t fromHost(std::uint16_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint16_t fromHost(std::uint16_t value) {
+      if (std::endian::native == std::endian::big) {
         return value;
       } else {
         return BSwap16(value);
       }
     }
 
-    constexpr std::uint32_t fromHost(std::uint32_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint32_t fromHost(std::uint32_t value) {
+      if (std::endian::native == std::endian::big) {
         return value;
       } else {
         return BSwap32(value);
       }
     }
 
-    constexpr std::uint64_t fromHost(std::uint64_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint64_t fromHost(std::uint64_t value) {
+      if (std::endian::native == std::endian::big) {
         return value;
       } else {
         return BSwap64(value);
       }
     }
 
-    constexpr std::uint16_t toHost(std::uint16_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint16_t toHost(std::uint16_t value) {
+      if (std::endian::native == std::endian::big) {
         return value;
       } else {
         return BSwap16(value);
       }
     }
 
-    constexpr std::uint32_t toHost(std::uint32_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint32_t toHost(std::uint32_t value) {
+      if (std::endian::native == std::endian::big) {
         return value;
       } else {
         return BSwap32(value);
       }
     }
 
-    constexpr std::uint64_t toHost(std::uint64_t value) {
-      if constexpr (std::endian::native == std::endian::big) {
+    inline std::uint64_t toHost(std::uint64_t value) {
+      if (std::endian::native == std::endian::big) {
         return value;
       } else {
         return BSwap64(value);