Skip to content

Commit 484c993

Browse files
authored
Merge pull request #757 from arkivanov/kotlin-1.9.10
Updated Kotlin to 1.9.10, Gradle to 8.0.1, AGP to 8.0.1, coroutines to 1.7.3
2 parents c7c729b + 749e631 commit 484c993

File tree

22 files changed

+336
-585
lines changed

22 files changed

+336
-585
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
uses: actions/setup-java@v3
2121
with:
2222
distribution: 'zulu'
23-
java-version: '11'
23+
java-version: '17'
2424
- name: Install dependencies
2525
if: matrix.os == 'ubuntu-latest'
2626
run: sudo apt-get update && sudo apt-get install libcurl4-openssl-dev libgtk-3-dev nodejs chromium-browser

.github/workflows/release.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
uses: actions/setup-java@v3
3535
with:
3636
distribution: 'zulu'
37-
java-version: '11'
37+
java-version: '17'
3838
- name: Validate Gradle Wrapper
3939
uses: gradle/wrapper-validation-action@v1
4040
- name: Release JVM, Android, JS, Linux
@@ -73,7 +73,7 @@ jobs:
7373
uses: actions/setup-java@v3
7474
with:
7575
distribution: 'zulu'
76-
java-version: '11'
76+
java-version: '17'
7777
- name: Select Xcode version
7878
uses: maxim-lobanov/setup-xcode@9a697e2b393340c3cacd97468baa318e4c883d98
7979
with:
@@ -101,7 +101,7 @@ jobs:
101101
uses: actions/setup-java@v3
102102
with:
103103
distribution: 'zulu'
104-
java-version: '11'
104+
java-version: '17'
105105
- name: Validate Gradle Wrapper
106106
uses: gradle/wrapper-validation-action@v1
107107
- name: Check JVM, Android, JS, Linux
@@ -130,7 +130,7 @@ jobs:
130130
uses: actions/setup-java@v3
131131
with:
132132
distribution: 'zulu'
133-
java-version: '11'
133+
java-version: '17'
134134
- name: Select Xcode version
135135
uses: maxim-lobanov/setup-xcode@9a697e2b393340c3cacd97468baa318e4c883d98
136136
with:

coroutines-interop/api/android/coroutines-interop.api

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,3 @@
1-
public final class com/badoo/reaktive/coroutinesinterop/BuildConfig {
2-
public static final field BUILD_TYPE Ljava/lang/String;
3-
public static final field DEBUG Z
4-
public static final field LIBRARY_PACKAGE_NAME Ljava/lang/String;
5-
public fun <init> ()V
6-
}
7-
81
public final class com/badoo/reaktive/coroutinesinterop/CompletableFromCoroutineKt {
92
public static final fun asCompletable (Lkotlin/jvm/functions/Function1;)Lcom/badoo/reaktive/completable/Completable;
103
public static final fun asCompletable (Lkotlin/jvm/functions/Function2;)Lcom/badoo/reaktive/completable/Completable;

gradle.properties

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,7 @@ android.useAndroidX=true
88
# Automatically convert third-party libraries to use AndroidX
99
android.enableJetifier=true
1010

11-
kotlin.mpp.enableCompatibilityMetadataVariant=true
1211
kotlin.mpp.androidSourceSetLayoutVersion=2
12+
13+
# For compatibility with Kotlin 1.9.0, see https://github.com/badoo/Reaktive/issues/697
14+
android.experimental.lint.version=8.1.0

gradle/libs.versions.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[versions]
2-
kotlin = "1.8.21"
3-
kotlinx-coroutines = "1.7.1"
2+
kotlin = "1.9.10"
3+
kotlinx-coroutines = "1.7.3"
44
detekt = "1.22.0"
55

66
[libraries]
@@ -14,11 +14,11 @@ kotlin-test-js = { module = "org.jetbrains.kotlin:kotlin-test-js", version.ref =
1414
kotlin-test-junit = { module = "org.jetbrains.kotlin:kotlin-test-junit", version.ref = "kotlin" }
1515
kotlin-test-annotations = { module = "org.jetbrains.kotlin:kotlin-test-annotations-common", version.ref = "kotlin" }
1616

17-
kotlinx-compatibility = "org.jetbrains.kotlinx:binary-compatibility-validator:0.13.0"
17+
kotlinx-compatibility = "org.jetbrains.kotlinx:binary-compatibility-validator:0.13.2"
1818
kotlinx-coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "kotlinx-coroutines" }
1919
kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "kotlinx-coroutines" }
2020

21-
android-plugin = "com.android.tools.build:gradle:7.3.1"
21+
android-plugin = "com.android.tools.build:gradle:8.0.2"
2222

2323
androidx-appcompat = "androidx.appcompat:appcompat:1.4.2"
2424
androidx-constraintLayout = "androidx.constraintlayout:constraintlayout:1.1.3"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.1-all.zip
44
networkTimeout=10000
55
zipStoreBase=GRADLE_USER_HOME
66
zipStorePath=wrapper/dists

includedBuild/gradleConfiguration/src/main/kotlin/com/badoo/reaktive/configuration/MppConfigurationPlugin.kt

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,15 @@ package com.badoo.reaktive.configuration
33
import com.android.build.gradle.BaseExtension
44
import com.badoo.reaktive.getLibrary
55
import org.gradle.api.Action
6+
import org.gradle.api.JavaVersion
67
import org.gradle.api.Plugin
78
import org.gradle.api.Project
89
import org.gradle.kotlin.dsl.apply
910
import org.gradle.kotlin.dsl.invoke
11+
import org.gradle.kotlin.dsl.withType
1012
import org.jetbrains.kotlin.gradle.dsl.JvmTarget
1113
import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
14+
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
1215

1316
class MppConfigurationPlugin : Plugin<Project> {
1417

@@ -137,9 +140,18 @@ class MppConfigurationPlugin : Plugin<Project> {
137140
minSdk = 1
138141
targetSdk = 29
139142
}
143+
compileOptions {
144+
sourceCompatibility(JavaVersion.VERSION_1_8)
145+
targetCompatibility(JavaVersion.VERSION_1_8)
146+
}
147+
}
148+
project.tasks.withType<KotlinCompile> {
149+
kotlinOptions {
150+
jvmTarget = "1.8"
151+
}
140152
}
141153
project.kotlin {
142-
android {
154+
androidTarget {
143155
publishLibraryVariants("release", "debug")
144156
disableIfUndefined(Target.JVM)
145157
}

includedBuild/gradleConfiguration/src/main/kotlin/com/badoo/reaktive/publish/PublishConfigurationPlugin.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import org.gradle.api.publish.maven.tasks.PublishToMavenRepository
1212
import org.gradle.api.publish.plugins.PublishingPlugin
1313
import org.gradle.jvm.tasks.Jar
1414
import org.gradle.kotlin.dsl.withType
15+
import org.gradle.plugins.signing.Sign
1516
import org.gradle.plugins.signing.SigningExtension
1617
import org.gradle.plugins.signing.SigningPlugin
1718
import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinMultiplatformPlugin
@@ -98,6 +99,12 @@ class PublishConfigurationPlugin : Plugin<Project> {
9899
useInMemoryPgpKeys(inMemoryKey, password)
99100
}
100101
}
102+
103+
// Workaround for https://github.com/gradle/gradle/issues/26091
104+
val signingTasks = project.tasks.withType<Sign>()
105+
project.tasks.withType<AbstractPublishToMaven>().configureEach {
106+
dependsOn(signingTasks)
107+
}
101108
}
102109

103110
private fun createFilteredPublishTasks(project: Project) {

0 commit comments

Comments
 (0)