Skip to content

Commit aa80982

Browse files
authored
fix compatible issue with gcc-9 (#72)
1 parent 654e359 commit aa80982

File tree

3 files changed

+23
-2
lines changed

3 files changed

+23
-2
lines changed

.github/workflows/ci.yml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,27 @@ jobs:
3939
path: bazel-disk
4040
key: bazel-disk-basic-${{matrix.compiler.name}}-${{matrix.mode.name}}-${{matrix.std.name}}-${{matrix.stdlib.name}}-${{matrix.feature.name}}-${{github.sha}}
4141

42+
compatible:
43+
strategy:
44+
fail-fast: false
45+
matrix:
46+
compiler: [{name: gcc-9, flag: --action_env=CC=gcc-9}]
47+
runs-on: ubuntu-20.04
48+
name: compatible-${{matrix.compiler.name}}
49+
steps:
50+
- uses: actions/checkout@v4
51+
- uses: actions/cache/restore@v4
52+
with:
53+
path: bazel-disk
54+
key: bazel-disk-compatible-${{matrix.compiler.name}}-${{github.sha}}
55+
restore-keys: bazel-disk-compatible-${{matrix.compiler.name}}
56+
- run: bazel test --disk_cache=bazel-disk --verbose_failures --test_output=errors ${{matrix.compiler.flag}} test/...
57+
- uses: actions/cache/save@v4
58+
if: always()
59+
with:
60+
path: bazel-disk
61+
key: bazel-disk-basic-${{matrix.compiler.name}}-${{github.sha}}
62+
4263
arenastring:
4364
strategy:
4465
fail-fast: false

src/babylon/concurrent/garbage_collector.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class GarbageCollector {
5959
private:
6060
class ReclaimTask {
6161
public:
62-
ReclaimTask() noexcept = default;
62+
ReclaimTask() = default;
6363
ReclaimTask(ReclaimTask&&) = default;
6464
ReclaimTask(const ReclaimTask&) = delete;
6565
ReclaimTask& operator=(ReclaimTask&&) = default;

src/babylon/executor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ struct AlwaysUseNewThreadExecutor : public Executor {
256256
class ThreadPoolExecutor : public Executor {
257257
public:
258258
// Use **this** in worker thread, so no copy nor move
259-
ThreadPoolExecutor() noexcept = default;
259+
ThreadPoolExecutor() = default;
260260
ThreadPoolExecutor(ThreadPoolExecutor&&) noexcept = delete;
261261
ThreadPoolExecutor(const ThreadPoolExecutor&) noexcept = delete;
262262
ThreadPoolExecutor& operator=(ThreadPoolExecutor&&) noexcept = delete;

0 commit comments

Comments
 (0)