Fix sonarcube

Author: vostres

src/main/java/com/bakdata/kserve/client/KServeClientV2.java

@@ -39,35 +39,37 @@
 @Slf4j
 public class KServeClientV2<T> extends KServeClient<InferenceRequest<T>> {
 
+    public static final String DETAIL_FIELD = "detail";
+    private static final String ERROR_FIELD = "error";
+
     @Builder
     KServeClientV2(
             final URL serviceBaseUrl, final String modelName, final OkHttpClient httpClient) {
         super(serviceBaseUrl, modelName, httpClient);
     }
 
+    private static String extractDetailMessage(final JsonNode detail) {
+        return detail.isArray() && !detail.isEmpty() ? detail.toString() : detail.asText();
+    }
+
+    private static String extractErrorFromParsedBody(final JsonNode root, final String stringBody) {
+        final JsonNode errorNode = root.get(ERROR_FIELD);
+        if (errorNode != null && !errorNode.isNull()) {
+            return errorNode.asText();
+        }
+        if (root.has(DETAIL_FIELD)) {
+            return extractDetailMessage(root.get(DETAIL_FIELD));
+        }
+        return "Unknown error occurred. Raw body: " + stringBody;
+    }
+
     @Override
     protected String extractErrorMessage(final String stringBody) {
         try {
             final JsonNode root = OBJECT_MAPPER.readTree(stringBody);
-
-            if (root.has("error") && !root.get("error").isNull()) {
-                return root.get("error").asText();
-            }
-
-            if (root.has("detail")) {
-                final JsonNode detail = root.get("detail");
-
-                if (detail.isArray() && !detail.isEmpty()) {
-                    return detail.toString();
-                }
-
-                return detail.asText();
-            }
-
-            return "Unknown error occurred. Raw body: " + stringBody;
-
+            return extractErrorFromParsedBody(root, stringBody);
         } catch (final JsonProcessingException e) {
-            log.warn("Could not parse error body as JSON: {}", stringBody);
+            log.warn("Could not parse error body as JSON: {}", stringBody, e);
             return stringBody;
         }
     }