get url from args

Author: bakito

README.md

@@ -17,7 +17,7 @@ Fetch ssl certificates from https urls and store them in different formats.
 Prints the certificates of a given URL.
 
 ```bash
-cert-fetcher --url https://www.foo.bar
+cert-fetcher https://www.foo.bar
 
 # All options
 cert-fetcher --help
@@ -28,7 +28,7 @@ cert-fetcher --help
 Stores the certificates from the given URL into a pem file.
 
 ```bash
-cert-fetcher pem --url https://www.foo.bar
+cert-fetcher pem https://www.foo.bar
 
 # All options
 cert-fetcher pem --help
@@ -39,7 +39,7 @@ cert-fetcher pem --help
 Stores the certificates from the given URL into a java keystore file.
 
 ```bash
-cert-fetcher jks --url https://www.foo.bar
+cert-fetcher jks https://www.foo.bar
 
 # All options
 cert-fetcher jks --help

cmd/jks.go

@@ -12,12 +12,14 @@ var (
 
 // jksCmd represents the jks command
 var jksCmd = &cobra.Command{
-	Version: version,
-	Use:     "jks",
-	Short:   "store the certificates into an java keystore",
-	Long:    "store the certificates into an java keystore",
+	Version:   version,
+	Use:       "jks [url]",
+	Short:     "store the certificates into an java keystore",
+	Long:      "store the certificates into an java keystore",
+	Args:      cobra.ExactArgs(1),
+	ValidArgs: []string{"url"},
 	RunE: func(cmd *cobra.Command, args []string) error {
-		return jks.Export(targetURL, certIndexes, jksSource, jksPassword, outputFile)
+		return jks.Export(args[0], certIndexes, jksSource, jksPassword, outputFile)
 	},
 }
 

cmd/pem.go

@@ -7,13 +7,14 @@ import (
 
 // pemCmd represents the pem command
 var pemCmd = &cobra.Command{
-	Version: version,
-	Use:     "pem",
-	Short:   "store the certificates as pem file",
-	Long:    "store the certificates as pem file",
-
+	Version:   version,
+	Use:       "pem [url]",
+	Short:     "store the certificates as pem file",
+	Long:      "store the certificates as pem file",
+	ValidArgs: []string{"url"},
+	Args:      cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) error {
-		return pem.ExportTo(targetURL, certIndexes, outputFile)
+		return pem.ExportTo(args[0], certIndexes, outputFile)
 	},
 }
 

cmd/root.go

@@ -9,20 +9,21 @@ import (
 )
 
 var (
-	targetURL   string
 	outputFile  string
 	certIndexes []int
 	version     string
 )
 
 // rootCmd represents the base command when called without any subcommands
 var rootCmd = &cobra.Command{
-	Version: version,
-	Use:     "cert-fetcher",
-	Short:   "Fetch client certificates from https urls",
-	Long:    "A go application that fetches public certificates from https sites and stores them into different output formates.",
+	Version:   version,
+	Use:       "cert-fetcher [url]",
+	Short:     "Fetch client certificates from https urls",
+	Long:      "A go application that fetches public certificates from https sites and stores them into different output formats.",
+	ValidArgs: []string{"url"},
+	Args:      cobra.ExactArgs(1),
 	RunE: func(cmd *cobra.Command, args []string) error {
-		return cert.Print(targetURL)
+		return cert.Print(args[0])
 	},
 }
 
@@ -36,8 +37,6 @@ func Execute() {
 }
 
 func init() {
-	rootCmd.PersistentFlags().StringVarP(&targetURL, "url", "u", "", "the URL to fetch the certificate from")
-	_ = rootCmd.MarkPersistentFlagRequired("url")
 	rootCmd.PersistentFlags().StringVarP(&outputFile, "out-file", "o", "", "the output file")
 	rootCmd.PersistentFlags().IntSliceVarP(&certIndexes, "import-at", "i", make([]int, 0), "import the certificates at the given indexes")
 }