Merge pull request #795 from balancer/fix-broken-create-tests

Fix broken create tests

Author: johngrantuk

test/anvil/anvil-global-setup.ts

@@ -162,9 +162,14 @@ function getAnvilOptions(
         forkUrl,
         port,
         forkBlockNumber,
+        mnemonic:
+            'you twelve word test phrase boat cat like this example dog car', // mnemonic for deterministic accounts - should not have delegated accounts
     };
 }
 
+// Counter to ensure unique ports for each fork instance
+let forkCounter = 0;
+
 // Controls the current running forks to avoid starting the same fork twice
 let runningForks: Record<number, Anvil> = {};
 
@@ -177,9 +182,14 @@ export async function stopAnvilForks() {
         }),
     );
     runningForks = {};
+    // Reset fork counter after stopping all forks to prevent unbounded growth
+    forkCounter = 0;
 }
 
 // Stop a specific anvil fork
+// Note: Since forks are no longer reused (each startFork() creates a new instance),
+// this function may not reliably find forks without tracking the exact port.
+// For cleanup, prefer using stopAnvilForks() which stops all forks.
 export async function stopAnvilFork(
     network: NetworkSetup,
     jobId = Number(process.env.VITEST_WORKER_ID) || 0,
@@ -188,8 +198,10 @@ export async function stopAnvilFork(
     const anvilOptions = getAnvilOptions(network, blockNumber);
 
     const defaultAnvilPort = 8545;
+    // Note: This port calculation doesn't account for forkCounter, so it may not find the fork
+    // if it was created with a counter offset. This function is kept for compatibility but
+    // stopAnvilForks() is recommended for cleanup.
     const port = (anvilOptions.port || defaultAnvilPort) + jobId;
-    // Avoid starting fork if it was running already
     if (!runningForks[port]) return;
 
     await runningForks[port].stop();
@@ -201,6 +213,9 @@ export async function stopAnvilFork(
     In vitest, each thread is assigned a unique, numerical id (`process.env.VITEST_POOL_ID`).
     When jobId is provided, the fork uses this id to create a different local rpc url (e.g. `http://127.0.0.1:<8545+jobId>/`
     so that tests can be run in parallel (depending on the number of threads of the host machine)
+    
+    IMPORTANT: Each call to startFork() creates a new fork instance with a unique port.
+    This ensures complete isolation between test suites, preventing state interference and snapshot collisions.
 */
 export async function startFork(
     network: NetworkSetup,
@@ -212,7 +227,11 @@ export async function startFork(
     const anvilOptions = getAnvilOptions(network, blockNumber);
 
     const defaultAnvilPort = 8545;
-    const port = (anvilOptions.port || defaultAnvilPort) + jobId;
+    const basePort = anvilOptions.port || defaultAnvilPort;
+    // Calculate unique port: basePort + jobId + (forkCounter * 100)
+    // This ensures each fork gets a unique port while maintaining network separation
+    const port = basePort + jobId + forkCounter * 100;
+    forkCounter++;
 
     if (!anvilOptions.forkUrl) {
         throw Error(
@@ -221,10 +240,11 @@ export async function startFork(
     }
     const rpcUrl = `http://127.0.0.1:${port}`;
 
-    console.log('checking rpcUrl', port, runningForks);
-
-    // Avoid starting fork if it was running already
-    if (runningForks[port]) return { rpcUrl };
+    console.log('Starting new fork', {
+        port,
+        forkBlockNumber: blockNumber ?? anvilOptions.forkBlockNumber,
+        runningForks: Object.keys(runningForks).length,
+    });
 
     // https://www.npmjs.com/package/@viem/anvil
     // Pass startTimeout directly to createAnvil - it defaults to 10_000ms

test/v3/createPool/liquidityBootstrapping/liquidityBootstrapping.integration.test.ts

@@ -26,11 +26,7 @@ import { ANVIL_NETWORKS, startFork } from '../../../anvil/anvil-global-setup';
 import { doCreatePool } from '../../../lib/utils/createPoolHelper';
 import { TOKENS } from 'test/lib/utils/addresses';
 import { MAX_UINT256, PublicWalletClient } from '@/utils';
-import {
-    lBPMigrationRouterAbi_V3,
-    vaultExtensionAbi_V3,
-    weightedPoolFactoryAbiExtended_V3,
-} from 'src/abi/';
+import { lBPMigrationRouterAbi_V3, vaultExtensionAbi_V3 } from 'src/abi/';
 import { assertInitPool } from 'test/lib/utils/initPoolHelper';
 import {
     setTokenBalances,
@@ -312,13 +308,14 @@ describe('create liquidityBootstrapping pool test', () => {
         );
 
         // extract the address of the created weighted pool from the transaction receipt
+        // The PoolMigrated event is emitted by the LBPMigrationRouter and contains the new weighted pool address
         const {
-            args: { pool: newWeightedPoolAddress },
+            args: { weightedPool: newWeightedPoolAddress },
         } = findEventInReceiptLogs({
             receipt: txOutput.transactionReceipt,
-            eventName: 'PoolCreated',
-            abi: weightedPoolFactoryAbiExtended_V3,
-            to: AddressProvider.WeightedPoolFactory(chainId),
+            eventName: 'PoolMigrated',
+            abi: lBPMigrationRouterAbi_V3,
+            to: AddressProvider.LBPoolMigrationRouter(chainId),
         });
 
         expect(txOutput.balanceDeltas[0]).toBeGreaterThan(0n); // WETH

test/v3/createPool/stable/stable.integration.test.ts

@@ -1,4 +1,4 @@
-// pnpm test -- v3/createPool/stable/stable.integration.test.ts
+// pnpm test test/v3/createPool/stable/stable.integration.test.ts
 
 import {
     Address,
@@ -35,7 +35,11 @@ import {
 } from 'test/lib/utils/helper';
 import { AddressProvider } from '@/entities/inputValidator/utils/addressProvider';
 
-const { rpcUrl } = await startFork(ANVIL_NETWORKS.SEPOLIA);
+const { rpcUrl } = await startFork(
+    ANVIL_NETWORKS.SEPOLIA,
+    undefined,
+    10140629n,
+);
 const protocolVersion = 3;
 const chainId = ChainId.SEPOLIA;
 const poolType = PoolType.Stable;

test/v3/createPool/stableSurge/stableSurge.integration.test.ts

@@ -1,4 +1,4 @@
-// pnpm test -- v3/createPool/stableSurge/stableSurge.integration.test.ts
+// pnpm test test/v3/createPool/stableSurge/stableSurge.integration.test.ts
 import {
     Address,
     createTestClient,
@@ -47,7 +47,11 @@ describe('create stableSurge pool test', () => {
     let poolAddress: Address;
 
     beforeAll(async () => {
-        ({ rpcUrl } = await startFork(ANVIL_NETWORKS.SEPOLIA));
+        ({ rpcUrl } = await startFork(
+            ANVIL_NETWORKS.SEPOLIA,
+            undefined,
+            10140629n,
+        ));
         client = createTestClient({
             mode: 'anvil',
             chain: CHAINS[chainId],

test/v3/createPool/weighted/weighted.integration.test.ts

@@ -1,4 +1,4 @@
-// pnpm test -- v3/createPool/weighted/weighted.integration.test.ts
+// pnpm test test/v3/createPool/weighted/weighted.integration.test.ts
 
 import {
     Address,
@@ -35,7 +35,11 @@ import {
 } from 'test/lib/utils/helper';
 import { AddressProvider } from '@/entities/inputValidator/utils/addressProvider';
 
-const { rpcUrl } = await startFork(ANVIL_NETWORKS.SEPOLIA);
+const { rpcUrl } = await startFork(
+    ANVIL_NETWORKS.SEPOLIA,
+    undefined,
+    10140629n,
+);
 const protocolVersion = 3;
 const chainId = ChainId.SEPOLIA;
 const poolType = PoolType.Weighted;

vitest.config.mts

@@ -28,6 +28,14 @@ export default defineConfig(({ mode }) => {
             setupFiles: ['/test/vitest-setup.ts'],
             globals: true,
             pool: 'forks',
+            // Limit concurrent forks to avoid overwhelming RPC providers with too many connections
+            // Each fork creates its own Anvil instance which makes RPC calls
+            poolOptions: {
+                forks: {
+                    maxForks: 3,
+                    minForks: 1,
+                },
+            },
             // Uncomment to debug suite excluding some tests
             // exclude: ['test/*weighted*.integration.*', 'node_modules', 'dist'],
             // Uncomment to run integration tests sequentially