Skip to content
This repository was archived by the owner on Aug 13, 2021. It is now read-only.

Add support for min and max queries on fields with date, time, and datetime types #6

Open
RickSnyder wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for min and max queries on fields with date, time, and datetime types #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ module.exports = (function () {
groupedResults.forEach(function(group, i) {
options.min.forEach(function(sumKey) {

var columnAttributes = schema[collectionName].attributes[sumKey];
var targetDataType = columnAttributes.type.toLowerCase();
var isDateType = targetDataType === 'datetime' || targetDataType === 'date' || targetDataType === 'time';

// keep track of current minimum
var min = Infinity;

Expand All @@ -200,10 +204,23 @@ module.exports = (function () {
if(item[sumKey] < min) {
min = item[sumKey];
}
} else if (isDateType) {
var dateValue = new Date(item[sumKey]);
if (!_.isNaN(dateValue.valueOf())) {
if (min === Infinity || dateValue.valueOf() < min.valueOf()) {
min = dateValue;
}
}
}
});

finishedResults[i][sumKey] = isFinite(min) ? min : null;
// convert min to correct data type before returning
if (isDateType) {
finishedResults[i][sumKey] = min === Infinity ? null : min.toJSON();
} else {
finishedResults[i][sumKey] = isFinite(min) ? min : null;
}

});
});
}
Expand All @@ -214,6 +231,10 @@ module.exports = (function () {
groupedResults.forEach(function(group, i) {
options.max.forEach(function(sumKey) {

var columnAttributes = schema[collectionName].attributes[sumKey];
var targetDataType = columnAttributes.type.toLowerCase();
var isDateType = targetDataType === 'datetime' || targetDataType === 'date' || targetDataType === 'time';

// keep track of current maximum
var max = -Infinity;

Expand All @@ -223,10 +244,23 @@ module.exports = (function () {
if(item[sumKey] > max) {
max = item[sumKey];
}
} else if (isDateType) {
var dateValue = new Date(item[sumKey]);
if (!_.isNaN(dateValue.valueOf())) {
if (max === -Infinity || dateValue.valueOf() > max.valueOf()) {
max = dateValue;
}
}
}
});

finishedResults[i][sumKey] = isFinite(max) ? max : null;
// convert max to correct data type before returning
if (isDateType) {
finishedResults[i][sumKey] = max === -Infinity ? null : max.toJSON();
} else {
finishedResults[i][sumKey] = isFinite(max) ? max : null;
}

});
});
}
Expand Down