Skip to content

Process parent records on join #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Process parent records on join #204

wants to merge 2 commits into from

Conversation

anotherpit
Copy link

Currently find() uses processor to cast result records, and join() does not. This PR adds processing to parent records of join() results. Child records still need to be processed.

@anotherpit anotherpit mentioned this pull request Oct 29, 2015
Closed
@devinivy
Copy link
Contributor

join() is often used internally– find would use it, but you'd never call it directly. Can you give an example of a failing case?

@particlebanana
Copy link
Contributor

Yes @anotherpit I need a failing test to show that this fixes it and so we don't get any regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anotherpit @devinivy @particlebanana