Skip to content

Commit 0384c64

Browse files
committed
Fix submit semaphores in VK_Resource_Usage test
Fix validation layer errors
1 parent 7da9fd2 commit 0384c64

2 files changed

Lines changed: 17 additions & 18 deletions

File tree

util/test/demos/vk/vk_resource_usage.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -673,6 +673,7 @@ RD_TEST(VK_Resource_Usage, VulkanGraphicsTest)
673673
setName(barrierCmd, "Barrier Command Buffer");
674674
vkBeginCommandBuffer(barrierCmd,
675675
vkh::CommandBufferBeginInfo(VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT));
676+
setMarker(barrierCmd, "Multiple Command Buffer Submits");
676677
vkh::cmdPipelineBarrier(
677678
barrierCmd, {},
678679
{vkh::BufferMemoryBarrier(VK_ACCESS_NONE, VK_ACCESS_NONE, barrierBuffer.buffer)});
@@ -1208,7 +1209,7 @@ RD_TEST(VK_Resource_Usage, VulkanGraphicsTest)
12081209

12091210
vkEndCommandBuffer(cmd);
12101211

1211-
Submit(0, 1, {cmd});
1212+
Submit(0, 3, {cmd});
12121213

12131214
cmd = GetCommandBuffer();
12141215

@@ -1280,15 +1281,13 @@ RD_TEST(VK_Resource_Usage, VulkanGraphicsTest)
12801281

12811282
vkEndCommandBuffer(cmd);
12821283

1283-
Submit(0, 1, {cmd});
1284+
Submit(1, 3, {cmd});
12841285

12851286
std::vector<VkCommandBuffer> cmds;
12861287
cmds.push_back(barrierCmd);
12871288
VkSubmitInfo submit = vkh::SubmitInfo(cmds);
12881289
for(uint32_t i = 0; i < 10; ++i)
12891290
{
1290-
if(i == 0)
1291-
setMarker(cmd, "Multiple Command Buffer Submits");
12921291
vkWaitForFences(device, 1, &barrerCmdSubmitFence, VK_TRUE, UINT64_MAX);
12931292
vkResetFences(device, 1, &barrerCmdSubmitFence);
12941293
CHECK_VKR(vkQueueSubmit(queue, 1, &submit, barrerCmdSubmitFence));
@@ -1310,7 +1309,7 @@ RD_TEST(VK_Resource_Usage, VulkanGraphicsTest)
13101309

13111310
vkEndCommandBuffer(cmd);
13121311

1313-
Submit(0, 1, {cmd});
1312+
Submit(2, 3, {cmd});
13141313

13151314
Present();
13161315
}

util/test/tests/Vulkan/VK_Resource_Usage.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -269,21 +269,21 @@ def check_capture(self):
269269
expectedUsage += [
270270
(255+countDrawIndirectCount,rd.ResourceUsage.Barrier)]
271271
if (res.name == "Barrier Buffer"):
272-
expectedUsage = [(228+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
273-
(235+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
274-
(242+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
275-
(249+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
276-
(256+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
277-
(263+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
278-
(270+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
272+
expectedUsage = [(229+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
273+
(237+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
274+
(245+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
275+
(253+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
276+
(261+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
277+
(269+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
279278
(277+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
280-
(284+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
281-
(291+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier)]
279+
(285+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
280+
(293+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
281+
(301+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier)]
282282
if (res.name == "Barrier2 Buffer"):
283-
expectedUsage = [(299+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
284-
(304+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
285-
(309+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
286-
(314+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier)]
283+
expectedUsage = [(309+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
284+
(314+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
285+
(319+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier),
286+
(324+countDrawIndirectCount+countNested+countDescBuffer,rd.ResourceUsage.Barrier)]
287287
elif res.type == rd.ResourceType.Texture:
288288
if (res.name == "Offscreen MSAA Image"):
289289
expectedUsage = [(11,rd.ResourceUsage.Barrier),

0 commit comments

Comments
 (0)