Switch to PER-CS ruleset for coding standard checking.

Author: hostep

.php-cs-fixer.php

@@ -9,27 +9,17 @@
 $config = new PhpCsFixer\Config();
 return $config
     ->setRules([
-        '@Symfony'               => true,
-        '@PSR12'                 => true,
-        'binary_operator_spaces' => ['default' => null, 'operators' => ['=>' => 'align']],
-        'concat_space'           => ['spacing' => 'one'],
-        'declare_strict_types'   => true,
-        'no_alias_functions'     => true,
-        'no_useless_sprintf'     => true,
-        'ordered_imports'        => [
-            'imports_order' => [
-                'class',
-                'function',
-                'const',
-            ],
-            'sort_algorithm' => 'alpha'
-        ],
-        'phpdoc_align'           => ['align' => 'left'],
-        'phpdoc_summary'         => false,
-        'self_accessor'          => true,
-        'single_line_throw'      => false,
-        'visibility_required'    => ['elements' => ['property', 'method']], // removed 'const' since we still support PHP 7.0 for now
-        'yoda_style'             => false,
+        '@PER-CS'                                          => true,
+        'binary_operator_spaces'                           => ['default' => 'at_least_single_space', 'operators' => ['=>' => 'align']],
+        'declare_strict_types'                             => true,
+        'no_alias_functions'                               => true,
+        'no_useless_sprintf'                               => true,
+        'nullable_type_declaration_for_default_null_value' => false, // should be 'true' when we drop support for PHP 7.0 which didn't support nullable types yet
+        'ordered_imports'                                  => ['sort_algorithm' => 'alpha'],
+        'phpdoc_align'                                     => ['align' => 'vertical'],
+        'phpdoc_separation'                                => ['skip_unlisted_annotations' => true],
+        'self_accessor'                                    => true,
+        'visibility_required'                              => ['elements' => ['property', 'method']], // removed 'const' since we still support PHP 7.0 for now
     ])
     ->setFinder($finder)
 ;

Exception/AlreadyRefreshingException.php

@@ -6,6 +6,4 @@
 
 use Magento\Framework\Exception\LocalizedException;
 
-class AlreadyRefreshingException extends LocalizedException
-{
-}
+class AlreadyRefreshingException extends LocalizedException {}

Exception/MissingConfigurationException.php

@@ -6,6 +6,4 @@
 
 use Magento\Framework\Exception\LocalizedException;
 
-class MissingConfigurationException extends LocalizedException
-{
-}
+class MissingConfigurationException extends LocalizedException {}

Exception/SerializationException.php

@@ -6,6 +6,4 @@
 
 use Magento\Framework\Exception\LocalizedException;
 
-class SerializationException extends LocalizedException
-{
-}
+class SerializationException extends LocalizedException {}

Makefile

@@ -11,7 +11,7 @@ check: checkstyle checkquality test
 .PHONY: checkstyle
 checkstyle:
 	vendor-bin/php-cs-fixer/vendor/bin/php-cs-fixer fix --dry-run --diff --stop-on-violation --allow-risky=yes
-	vendor-bin/phpcs/vendor/bin/phpcs -s --standard=Magento2 --exclude=Magento2.Security.InsecureFunction,Magento2.Commenting.ClassPropertyPHPDocFormatting,Magento2.Annotation.MethodAnnotationStructure,Magento2.Annotation.MethodArguments,PSR12.Properties.ConstantVisibility --ignore=./vendor/,./vendor-bin/ .
+	vendor-bin/phpcs/vendor/bin/phpcs -s --standard=Magento2 --exclude=Magento2.Security.InsecureFunction,Magento2.Commenting.ClassPropertyPHPDocFormatting,Magento2.Annotation.MethodAnnotationStructure,Magento2.Annotation.MethodArguments,PSR12.Properties.ConstantVisibility,PSR2.Classes.ClassDeclaration,Squiz.WhiteSpace.ScopeClosingBrace --ignore=./vendor/,./vendor-bin/ .
 	vendor-bin/phpcs/vendor/bin/phpcs -s --standard=PHPCompatibility --runtime-set testVersion 7.0- --ignore=./vendor/,./vendor-bin/,./Test/ .
 	vendor-bin/phpcs/vendor/bin/phpcs -s --standard=PHPCompatibility --runtime-set testVersion 7.1- ./Test/
 	vendor/bin/composer normalize --dry-run