Added void return types where possible, now that the minimum supported PHP version is 7.1

Author: hostep

Checker/Catalog/Category/UrlPath.php

@@ -164,7 +164,7 @@ public function getCalculatedUrlPathForCategory(Category $category, int $storeId
         ));
     }
 
-    private function fetchAllCategoriesWithUrlPathCalculatedByUrlKey()
+    private function fetchAllCategoriesWithUrlPathCalculatedByUrlKey(): void
     {
         $this->calculatedUrlPathPerCategoryAndStoreId = [];
 

Checker/Catalog/Product/UrlKey/DuplicateUrlKey.php

@@ -118,7 +118,7 @@ private function checkForDuplicatedUrlKeyAttributeValues(): array
     /**
      * @param ProductCollection<ProductModel> $collection
      */
-    private function storeProductUrlKeyData(int $storeId, ProductCollection $collection)
+    private function storeProductUrlKeyData(int $storeId, ProductCollection $collection): void
     {
         foreach ($collection as $product) {
             assert(is_numeric($product->getEntityId()));

Console/Command/CheckCategoryUrlKeys.php

@@ -37,7 +37,7 @@ public function __construct(
         parent::__construct();
     }
 
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('catalog:category:integrity:urlkey');
         $this->setDescription('Checks data integrity of the values of the url_key category attribute.');

Console/Command/CheckCategoryUrlPaths.php

@@ -37,7 +37,7 @@ public function __construct(
         parent::__construct();
     }
 
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('catalog:category:integrity:urlpath');
         $this->setDescription('Checks data integrity of the values of the url_path category attribute.');

Console/Command/CheckProductUrlKeys.php

@@ -41,7 +41,7 @@ public function __construct(
         parent::__construct();
     }
 
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('catalog:product:integrity:urlkey');
         $this->setDescription('Checks data integrity of the values of the url_key product attribute.');

Console/Command/CheckProductUrlPaths.php

@@ -37,7 +37,7 @@ public function __construct(
         parent::__construct();
     }
 
-    protected function configure()
+    protected function configure(): void
     {
         $this->setName('catalog:product:integrity:urlpath');
         $this->setDescription('Checks data integrity of the values of the url_path product attribute.');

Console/Progress.php

@@ -24,12 +24,12 @@ public function __construct()
         $this->format = '';
     }
 
-    public function setOutput(OutputInterface $output)
+    public function setOutput(OutputInterface $output): void
     {
         $this->output = $output;
     }
 
-    public function initProgressBar(int $redrawFequency, string $format, string $message)
+    public function initProgressBar(int $redrawFequency, string $format, string $message): void
     {
         if ($this->canOutput()) {
             $this->progressBar = new ProgressBar($this->output);
@@ -42,35 +42,35 @@ public function initProgressBar(int $redrawFequency, string $format, string $mes
         }
     }
 
-    public function setGuestimatedSize(int $nrOfIndexes, int $sizePerIndex)
+    public function setGuestimatedSize(int $nrOfIndexes, int $sizePerIndex): void
     {
         for ($i = 0; $i < $nrOfIndexes; ++$i) {
             $this->sizeByIndex[$i] = $sizePerIndex;
         }
         $this->updateMaxSteps();
     }
 
-    public function updateExpectedSize(int $index, int $size)
+    public function updateExpectedSize(int $index, int $size): void
     {
         $this->sizeByIndex[$index] = $size;
         $this->updateMaxSteps();
     }
 
-    public function advance()
+    public function advance(): void
     {
         if ($this->canOutput()) {
             $this->progressBar->advance();
         }
     }
 
-    public function setMessage(string $message)
+    public function setMessage(string $message): void
     {
         if ($this->canOutput()) {
             $this->progressBar->setMessage($message);
         }
     }
 
-    public function finish()
+    public function finish(): void
     {
         if ($this->canOutput()) {
             $this->progressBar->finish();
@@ -82,7 +82,7 @@ private function canOutput(): bool
         return $this->output !== null;
     }
 
-    private function updateMaxSteps()
+    private function updateMaxSteps(): void
     {
         if ($this->canOutput()) {
             $newMaxStepsValue = (int) array_sum($this->sizeByIndex);

Cron/CheckCategoryUrlKey.php

@@ -19,7 +19,7 @@ public function __construct(
         $this->urlKeyUpdater = $urlKeyUpdater;
     }
 
-    public function execute()
+    public function execute(): void
     {
         $this->urlKeyUpdater->refresh(MetaStorage::INITIATOR_CRON);
     }

Cron/CheckCategoryUrlPath.php

@@ -19,7 +19,7 @@ public function __construct(
         $this->urlPathUpdater = $urlPathUpdater;
     }
 
-    public function execute()
+    public function execute(): void
     {
         $this->urlPathUpdater->refresh(MetaStorage::INITIATOR_CRON);
     }

Cron/CheckProductUrlKey.php

@@ -19,7 +19,7 @@ public function __construct(
         $this->urlKeyUpdater = $urlKeyUpdater;
     }
 
-    public function execute()
+    public function execute(): void
     {
         $this->urlKeyUpdater->refresh(MetaStorage::INITIATOR_CRON);
     }