Skip to content

Commit be8cd95

Browse files
committed
Merge branch 'v1-develop' into v1
2 parents 28b6cf1 + d1c799e commit be8cd95

File tree

7 files changed

+310
-220
lines changed

7 files changed

+310
-220
lines changed

Checker/Catalog/Category/UrlPath.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,9 @@ private function fetchAllCategoriesWithUrlPathCalculatedByUrlKey()
163163
if (array_key_exists($id, $tempCatData)) {
164164
$calculatedUrlPath[] = $tempCatData[$id]['url_key'];
165165
} else {
166-
throw new LocalizedException(__("Can't find category with id: '$id'"));
166+
throw new LocalizedException(__(
167+
"Can't find category with id: '$id' (this id comes from a category's path attribute)"
168+
));
167169
}
168170
}
169171

Updater/Catalog/Category/UrlKey.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,17 @@ public function refresh(string $initiator): array
4444
$this->metaStorage->setErrorMessage($storageIdentifier, '');
4545
$this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);
4646

47-
$categoryData = $this->urlKeyChecker->execute();
48-
$this->storage->write($storageIdentifier, $categoryData);
47+
try {
48+
$categoryData = $this->urlKeyChecker->execute();
49+
$this->storage->write($storageIdentifier, $categoryData);
4950

50-
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
51+
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
52+
} catch (\Throwable $ex) {
53+
$this->metaStorage->clearStatus($storageIdentifier);
54+
$this->metaStorage->setErrorMessage($storageIdentifier, $ex->getMessage());
55+
56+
throw $ex;
57+
}
5158

5259
return $categoryData;
5360
}

Updater/Catalog/Category/UrlPath.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,17 @@ public function refresh(string $initiator): array
4444
$this->metaStorage->setErrorMessage($storageIdentifier, '');
4545
$this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);
4646

47-
$categoryData = $this->urlPathChecker->execute();
48-
$this->storage->write($storageIdentifier, $categoryData);
47+
try {
48+
$categoryData = $this->urlPathChecker->execute();
49+
$this->storage->write($storageIdentifier, $categoryData);
4950

50-
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
51+
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
52+
} catch (\Throwable $ex) {
53+
$this->metaStorage->clearStatus($storageIdentifier);
54+
$this->metaStorage->setErrorMessage($storageIdentifier, $ex->getMessage());
55+
56+
throw $ex;
57+
}
5158

5259
return $categoryData;
5360
}

Updater/Catalog/Product/UrlKey.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,17 @@ public function refresh(string $initiator): array
4444
$this->metaStorage->setErrorMessage($storageIdentifier, '');
4545
$this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);
4646

47-
$productData = $this->urlKeyChecker->execute();
48-
$this->storage->write($storageIdentifier, $productData);
47+
try {
48+
$productData = $this->urlKeyChecker->execute();
49+
$this->storage->write($storageIdentifier, $productData);
4950

50-
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
51+
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
52+
} catch (\Throwable $ex) {
53+
$this->metaStorage->clearStatus($storageIdentifier);
54+
$this->metaStorage->setErrorMessage($storageIdentifier, $ex->getMessage());
55+
56+
throw $ex;
57+
}
5158

5259
return $productData;
5360
}

Updater/Catalog/Product/UrlPath.php

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,17 @@ public function refresh(string $initiator): array
4444
$this->metaStorage->setErrorMessage($storageIdentifier, '');
4545
$this->metaStorage->setStartRefreshing($storageIdentifier, $initiator);
4646

47-
$productData = $this->urlPathChecker->execute();
48-
$this->storage->write($storageIdentifier, $productData);
47+
try {
48+
$productData = $this->urlPathChecker->execute();
49+
$this->storage->write($storageIdentifier, $productData);
4950

50-
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
51+
$this->metaStorage->setFinishedRefreshing($storageIdentifier);
52+
} catch (\Throwable $ex) {
53+
$this->metaStorage->clearStatus($storageIdentifier);
54+
$this->metaStorage->setErrorMessage($storageIdentifier, $ex->getMessage());
55+
56+
throw $ex;
57+
}
5158

5259
return $productData;
5360
}

0 commit comments

Comments
 (0)