Added unique index per row entry for the admin grids, prevents duplicated rows from showing up after sorting the grid a few times. Fixes #6

hostep · hostep · commit dc53b31ec18d · 2020-06-26T17:34:37.000+02:00
diff --git a/Model/ResourceModel/Catalog/Category/UrlKeyCollection.php b/Model/ResourceModel/Catalog/Category/UrlKeyCollection.php
@@ -73,6 +73,8 @@ public function loadData($printQuery = false, $logQuery = false)
      */
     public function createDataObject(array $arguments = []): DataObject
     {
+        $arguments['hash'] = sha1(json_encode($arguments) ?: '');
+
         $obj = $this->_entityFactory->create($this->_itemObjectClass, ['data' => $arguments]);
 
         $attributes = [];
diff --git a/Model/ResourceModel/Catalog/Category/UrlPathCollection.php b/Model/ResourceModel/Catalog/Category/UrlPathCollection.php
@@ -73,6 +73,8 @@ public function loadData($printQuery = false, $logQuery = false)
      */
     public function createDataObject(array $arguments = []): DataObject
     {
+        $arguments['hash'] = sha1(json_encode($arguments) ?: '');
+
         $obj = $this->_entityFactory->create($this->_itemObjectClass, ['data' => $arguments]);
 
         $attributes = [];
diff --git a/Model/ResourceModel/Catalog/Product/UrlKeyCollection.php b/Model/ResourceModel/Catalog/Product/UrlKeyCollection.php
@@ -73,6 +73,8 @@ public function loadData($printQuery = false, $logQuery = false)
      */
     public function createDataObject(array $arguments = []): DataObject
     {
+        $arguments['hash'] = sha1(json_encode($arguments) ?: '');
+
         $obj = $this->_entityFactory->create($this->_itemObjectClass, ['data' => $arguments]);
 
         $attributes = [];
diff --git a/Model/ResourceModel/Catalog/Product/UrlPathCollection.php b/Model/ResourceModel/Catalog/Product/UrlPathCollection.php
@@ -73,6 +73,8 @@ public function loadData($printQuery = false, $logQuery = false)
      */
     public function createDataObject(array $arguments = []): DataObject
     {
+        $arguments['hash'] = sha1(json_encode($arguments) ?: '');
+
         $obj = $this->_entityFactory->create($this->_itemObjectClass, ['data' => $arguments]);
 
         $attributes = [];
diff --git a/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_category_urlkey.xml b/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_category_urlkey.xml
@@ -19,14 +19,14 @@
         <argument name="dataProvider" xsi:type="configurableObject">
             <argument name="class" xsi:type="string">Magento\Framework\View\Element\UiComponent\DataProvider\DataProvider</argument>
             <argument name="name" xsi:type="string">baldwin_urldataintegritychecker_grid_catalog_category_urlkey_data_source</argument>
-            <argument name="primaryFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
-            <argument name="requestFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
+            <argument name="primaryFieldName" xsi:type="string">hash</argument>
+            <argument name="requestFieldName" xsi:type="string">hash</argument>
             <argument name="data" xsi:type="array">
                 <item name="config" xsi:type="array">
                     <item name="component" xsi:type="string">Magento_Ui/js/grid/provider</item>
                     <item name="update_url" xsi:type="url" path="mui/index/render"/>
                     <item name="storageConfig" xsi:type="array">
-                        <item name="indexField" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</item>
+                        <item name="indexField" xsi:type="string">hash</item>
                     </item>
                 </item>
             </argument>
diff --git a/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_category_urlpath.xml b/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_category_urlpath.xml
@@ -19,14 +19,14 @@
         <argument name="dataProvider" xsi:type="configurableObject">
             <argument name="class" xsi:type="string">Magento\Framework\View\Element\UiComponent\DataProvider\DataProvider</argument>
             <argument name="name" xsi:type="string">baldwin_urldataintegritychecker_grid_catalog_category_urlpath_data_source</argument>
-            <argument name="primaryFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
-            <argument name="requestFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
+            <argument name="primaryFieldName" xsi:type="string">hash</argument>
+            <argument name="requestFieldName" xsi:type="string">hash</argument>
             <argument name="data" xsi:type="array">
                 <item name="config" xsi:type="array">
                     <item name="component" xsi:type="string">Magento_Ui/js/grid/provider</item>
                     <item name="update_url" xsi:type="url" path="mui/index/render"/>
                     <item name="storageConfig" xsi:type="array">
-                        <item name="indexField" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</item>
+                        <item name="indexField" xsi:type="string">hash</item>
                     </item>
                 </item>
             </argument>
diff --git a/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_product_urlkey.xml b/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_product_urlkey.xml
@@ -19,14 +19,14 @@
         <argument name="dataProvider" xsi:type="configurableObject">
             <argument name="class" xsi:type="string">Magento\Framework\View\Element\UiComponent\DataProvider\DataProvider</argument>
             <argument name="name" xsi:type="string">baldwin_urldataintegritychecker_grid_catalog_product_urlkey_data_source</argument>
-            <argument name="primaryFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
-            <argument name="requestFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
+            <argument name="primaryFieldName" xsi:type="string">hash</argument>
+            <argument name="requestFieldName" xsi:type="string">hash</argument>
             <argument name="data" xsi:type="array">
                 <item name="config" xsi:type="array">
                     <item name="component" xsi:type="string">Magento_Ui/js/grid/provider</item>
                     <item name="update_url" xsi:type="url" path="mui/index/render"/>
                     <item name="storageConfig" xsi:type="array">
-                        <item name="indexField" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</item>
+                        <item name="indexField" xsi:type="string">hash</item>
                     </item>
                 </item>
             </argument>
diff --git a/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_product_urlpath.xml b/view/adminhtml/ui_component/baldwin_urldataintegritychecker_grid_catalog_product_urlpath.xml
@@ -19,14 +19,14 @@
         <argument name="dataProvider" xsi:type="configurableObject">
             <argument name="class" xsi:type="string">Magento\Framework\View\Element\UiComponent\DataProvider\DataProvider</argument>
             <argument name="name" xsi:type="string">baldwin_urldataintegritychecker_grid_catalog_product_urlpath_data_source</argument>
-            <argument name="primaryFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
-            <argument name="requestFieldName" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</argument>
+            <argument name="primaryFieldName" xsi:type="string">hash</argument>
+            <argument name="requestFieldName" xsi:type="string">hash</argument>
             <argument name="data" xsi:type="array">
                 <item name="config" xsi:type="array">
                     <item name="component" xsi:type="string">Magento_Ui/js/grid/provider</item>
                     <item name="update_url" xsi:type="url" path="mui/index/render"/>
                     <item name="storageConfig" xsi:type="array">
-                        <item name="indexField" xsi:type="string">just-by-specifying-some-attribute-which-doesnt-exists-works-here</item>
+                        <item name="indexField" xsi:type="string">hash</item>
                     </item>
                 </item>
             </argument>

Original file line number	Diff line number	Diff line change
`@@ -73,6 +73,8 @@ public function loadData($printQuery = false, $logQuery = false)`
`73`	`73`	`*/`
`74`	`74`	`public function createDataObject(array $arguments = []): DataObject`
`75`	`75`	`{`
	`76`	`+ $arguments['hash'] = sha1(json_encode($arguments) ?: '');`
	`77`	`+`
`76`	`78`	`$obj = $this->_entityFactory->create($this->_itemObjectClass, ['data' => $arguments]);`
`77`	`79`
`78`	`80`	`$attributes = [];`