Skip to content

Commit e288906

Browse files
committed
Played around a bit with phpstan 1.10.x's 'lie detector' and found some comments we can remove.
1 parent f36bbdc commit e288906

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

Test/Checker/Catalog/Product/UrlKey/DuplicateUrlKeyTest.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
use Magento\Catalog\Model\ResourceModel\Product\Collection as ProductCollection;
1414
use Magento\Catalog\Model\ResourceModel\Product\CollectionFactory as ProductCollectionFactory;
1515
use Magento\Framework\DataObject;
16-
use PHPUnit\Framework\MockObject\MockObject;
1716
use PHPUnit\Framework\TestCase;
1817

1918
class DuplicateUrlKeyTest extends TestCase
@@ -48,7 +47,6 @@ function ($productData) use ($storeId) {
4847

4948
$collectionsPerStoreId = array_map(
5049
function ($productsData) {
51-
/** @var MockObject $productCollectionMock */
5250
$productCollectionMock = $this->getMockBuilder(ProductCollection::class)
5351
->disableOriginalConstructor()
5452
->getMock();
@@ -74,7 +72,6 @@ function ($productsData) {
7472
$dataPerStoreId
7573
);
7674

77-
/** @var StoresUtil&MockObject */
7875
$storesUtilMock = $this
7976
->getMockBuilder(StoresUtil::class)
8077
->disableOriginalConstructor()
@@ -83,13 +80,11 @@ function ($productsData) {
8380
->method('getAllStoreIds')
8481
->willReturn($storeIds);
8582

86-
/** @var Progress&MockObject */
8783
$progressMock = $this
8884
->getMockBuilder(Progress::class)
8985
->disableOriginalConstructor()
9086
->getMock();
9187

92-
/** @var ProductCollectionFactory&MockObject */
9388
$productCollectionFactoryMock = $this
9489
->getMockBuilder(ProductCollectionFactory::class)
9590
->disableOriginalConstructor()
@@ -110,7 +105,6 @@ function ($productsData) {
110105
->method('containsValue')
111106
->willReturn(true);
112107

113-
/** @var AttributeScopeOverriddenValueFactory&MockObject */
114108
$attributeScopeOverriddenValueFactoryMock = $this
115109
->getMockBuilder(AttributeScopeOverriddenValueFactory::class)
116110
->disableOriginalConstructor()
@@ -120,7 +114,6 @@ function ($productsData) {
120114
->method('create')
121115
->willReturn($attributeScopeOverriddenValueMock);
122116

123-
/** @var ConfigUtil&MockObject */
124117
$configUtilMock = $this
125118
->getMockBuilder(ConfigUtil::class)
126119
->disableOriginalConstructor()

Test/Storage/CacheStorageTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
use Baldwin\UrlDataIntegrityChecker\Storage\CacheStorage;
88
use Magento\Framework\App\Cache as AppCache;
9-
use PHPUnit\Framework\MockObject\MockObject;
109
use PHPUnit\Framework\TestCase;
1110

1211
class CacheStorageTest extends TestCase
@@ -19,7 +18,6 @@ public function testUpdatingNonExisting()
1918
'key2' => 'value2',
2019
];
2120

22-
/** @var AppCache&MockObject */
2321
$cacheMock = $this
2422
->getMockBuilder(AppCache::class)
2523
->disableOriginalConstructor()
@@ -57,7 +55,6 @@ public function testUpdatingExisting()
5755
'key3' => 'value3',
5856
];
5957

60-
/** @var AppCache&MockObject */
6158
$cacheMock = $this
6259
->getMockBuilder(AppCache::class)
6360
->disableOriginalConstructor()
@@ -95,7 +92,6 @@ public function testClear()
9592

9693
$expectedData = [];
9794

98-
/** @var AppCache&MockObject */
9995
$cacheMock = $this
10096
->getMockBuilder(AppCache::class)
10197
->disableOriginalConstructor()

0 commit comments

Comments
 (0)