Added duplicate url key checker for categories, this uses the calculated url path's to determine this.

Author: hostep

Checker/Catalog/Category/UrlKey/DuplicateUrlKey.php

@@ -4,8 +4,28 @@
 
 namespace Baldwin\UrlDataIntegrityChecker\Checker\Catalog\Category\UrlKey;
 
+use Baldwin\UrlDataIntegrityChecker\Checker\Catalog\Category\UrlPath as UrlPathChecker;
+use Baldwin\UrlDataIntegrityChecker\Util\Stores as StoresUtil;
+
 class DuplicateUrlKey
 {
+    const DUPLICATED_PROBLEM_DESCRIPTION =
+          '%s categories were found which have a duplicated url_key value: "%s" within the same parent.'
+        . ' Please fix because this will cause problems.';
+
+    private $storesUtil;
+    private $urlPathChecker;
+    private $urlPathsInfo;
+
+    public function __construct(
+        StoresUtil $storesUtil,
+        UrlPathChecker $urlPathChecker
+    ) {
+        $this->storesUtil = $storesUtil;
+        $this->urlPathChecker = $urlPathChecker;
+        $this->urlPathsInfo = [];
+    }
+
     /**
      * @return array<array<string, mixed>>
      */
@@ -23,8 +43,59 @@ private function checkForDuplicatedUrlKeyAttributeValues(): array
     {
         $categoriesWithProblems = [];
 
-        // TODO !!!!!
+        $storeIds = $this->storesUtil->getAllStoreIds();
+        foreach ($storeIds as $storeId) {
+            $categoryUrlPaths = $this->getCategoryUrlPathsByStoreId($storeId);
+            $urlPathsCount = array_count_values($categoryUrlPaths);
+
+            foreach ($urlPathsCount as $urlPath => $count) {
+                if ($count === 1) {
+                    continue;
+                }
+
+                $categories = $this->urlPathsInfo[$urlPath];
+
+                foreach ($categories as $category) {
+                    $categoriesWithProblems[] = [
+                        'catId'   => (int) $category->getEntityId(),
+                        'name'    => $category->getName(),
+                        'storeId' => $storeId,
+                        'problem' => sprintf(
+                            self::DUPLICATED_PROBLEM_DESCRIPTION,
+                            $count,
+                            $category->getUrlKey()
+                        ),
+                    ];
+                }
+            }
+        }
 
         return $categoriesWithProblems;
     }
+
+    /**
+     * @return array<string>
+     */
+    private function getCategoryUrlPathsByStoreId(int $storeId): array
+    {
+        $urlPaths = [];
+
+        $categories = $this->urlPathChecker->getAllVisibleCategoriesWithStoreId($storeId);
+        foreach ($categories as $category) {
+            $urlPath = $this->urlPathChecker->getCalculatedUrlPathForCategory($category, $storeId);
+
+            $rootCatId = 0;
+            $path = $category->getPath() ?: '';
+            if (preg_match('#^(\d+)/(\d+)/.+#', $path, $matches) === 1) {
+                $rootCatId = $matches[2];
+            }
+
+            $urlPath = $rootCatId . UrlPathChecker::URL_PATH_SEPARATOR . $urlPath;
+
+            $urlPaths[] = $urlPath;
+            $this->urlPathsInfo[$urlPath][] = $category;
+        }
+
+        return $urlPaths;
+    }
 }

Checker/Catalog/Category/UrlPath.php

@@ -91,7 +91,7 @@ public function checkForIncorrectUrlPathAttributeValues(): array
     /**
      * @return CategoryCollection<Category>
      */
-    private function getAllVisibleCategoriesWithStoreId(int $storeId): CategoryCollection
+    public function getAllVisibleCategoriesWithStoreId(int $storeId): CategoryCollection
     {
         $categories = $this->categoryCollectionFactory->create()
             ->addAttributeToSelect('name')
@@ -111,7 +111,7 @@ private function doesCategoryUrlPathMatchCalculatedUrlPath(Category $category, i
         return $calculatedUrlPath === $currentUrlPath;
     }
 
-    private function getCalculatedUrlPathForCategory(Category $category, int $storeId): string
+    public function getCalculatedUrlPathForCategory(Category $category, int $storeId): string
     {
         if ($this->calculatedUrlPathPerCategoryAndStoreId === null) {
             $this->fetchAllCategoriesWithUrlPathCalculatedByUrlKey();