Skip to content

Commit deb3fa2

Browse files
Merge pull request #50 from balena-io-modules/revert-matchit-update
Revert matchit update
2 parents f215220 + a00bfa9 commit deb3fa2

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ repository = "https://github.com/balena-io-modules/mahler-rs"
1414
anyhow = "1.0.97"
1515
json-patch = "4"
1616
jsonptr = "0.7.1"
17-
# FIXME: this is using the revision for https://github.com/ibraheemdev/matchit/pull/76
18-
# revert to using only version once a new release (>0.8.6) of matchit is available
19-
matchit = { version = "0.8.6", git = "https://github.com/ibraheemdev/matchit.git", rev = "8fef456b044ec84532dea99f1857177b90d416e0" }
17+
# FIXME: this needs bumping once the fix in https://github.com/ibraheemdev/matchit/pull/76
18+
# makes it to a new release
19+
matchit = { version = "0.8.4" }
2020
serde = "1.0.197"
2121
serde_json = "1.0.120"
2222
thiserror = "2"

src/planner/distance.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ impl Distance {
9191
self.0.is_empty()
9292
}
9393

94-
pub fn iter(&self) -> Iter<Operation> {
94+
pub fn iter(&self) -> Iter<'_, Operation> {
9595
self.0.iter()
9696
}
9797

src/planner/domain.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ impl Domain {
189189
/// Find matches for the given path in the domain
190190
/// the matches are sorted in order that they should be
191191
/// tested
192-
pub(crate) fn find_matching_jobs(&self, path: &str) -> Option<(PathArgs, Iter<Job>)> {
192+
pub(crate) fn find_matching_jobs(&self, path: &str) -> Option<(PathArgs, Iter<'_, Job>)> {
193193
self.router
194194
.at(path)
195195
.map(|matched| (PathArgs::from(matched.params), matched.value.iter()))
@@ -326,7 +326,9 @@ mod tests {
326326
}
327327

328328
// See: https://github.com/ibraheemdev/matchit/issues/75
329+
// we ignore it for now until matchit releases a new version
329330
#[test]
331+
#[ignore]
330332
fn test_finds_jobs_for_empty_paths() {
331333
let func = |view: View<()>| view;
332334
let domain = Domain::new()

0 commit comments

Comments
 (0)