SDWire: only takes milliseconds to change

[perezmeyer]

Currently the code reads:

    async toggleMux(state: string): Promise<void> {
        if(state === 'host'){
            console.log('Switching SD card to host');
            await execAsync('sd-mux-ctrl --ts -v 0');
            // it can take some time before the mux is toggled - so just to be sure, we can add some delay here
            await delay(5000);
        } else if(state === 'dut'){
            console.log('Switching SD card to DUT');
            await execAsync('sd-mux-ctrl --dut -v 0');
            // it can take some time before the mux is toggled - so just to be sure, we can add some delay here
            await delay(5000);
        }
    }

SDWire takes just a few milliseconds to switch. If the delay is expressed in milliseconds I would say reduce that to 500.

[perezmeyer]

@rcooke-warwick @vipulgupta2048 Seems I can not assign issues, so pinging you here.

[rcooke-warwick]

hey @vipulgupta2048 @perezmeyer , here's my opinion on this change:

• I agree that 5000ms/5s is too long of a delay, and we could reduce it
• I think that reducing it to half a second may be too short. I'm sure the MUX itself does toggle much faster than that, but before, when these command line commands have been wrapped in node subprocesses as they are here, I've seen pretty inconsistant behaviour
• To put things into perspective, the test suite in full takes over an hour on the faster device types. This optimisation that saves 10 seconds, is a negligable improvement to that time - but if reducing the delay to so "small" an amount introduces unpredictable behaviour some of the time, it may not be worth it.

[perezmeyer]

Well, that sounds like a bug in node code... but OK, I'll increase it to 1s