use s3 to upload lambdas

Author: dashzt

blambda/deploy.py

@@ -267,7 +267,10 @@ def publish(name, role, zipfile, options, dryrun):
     Returns:
          str: the arn of the new or updated function
     """
-    client = clients.lambda_client
+    AWS_REGION = "us-east-1"
+    client = boto3.client('lambda', region_name=AWS_REGION)
+    s3_client = boto3.client('s3', region_name=AWS_REGION)
+
     options.pop('name', None)
     sha = git_sha()
     mods = "!" * git_local_mods()
@@ -278,41 +281,36 @@ def publish(name, role, zipfile, options, dryrun):
 
     with open(zipfile, 'rb') as f:
         file_bytes = f.read()
-        print("Function Package: {} bytes".format(len(file_bytes)))
-    if not dryrun:
-        try:
-            # TODO: Remove this once all py 3.8 lambdas are deployed on prod
-            # Added below code to update lambda runtime first and then deploy it
-            # cprint("Updating lambda function configuration - todo: remove", 'yellow')
-            # response = client.update_function_configuration(
-            #     FunctionName=name,
-            #     **options
-            # )
+        print("Function Package: {} bytes".format(len(file_bytes)))    
 
-            # time.sleep(15)
+    bucket_name = "balihoo-lambda-deployments-prod" 
+    s3_key = f"{name}-{sha}.zip"
 
+    if not dryrun:
+        # Upload to S3
+        cprint(f"Uploading {zipfile} to s3://{bucket_name}/{s3_key}", 'yellow')
+        s3_client.upload_file(zipfile, bucket_name, s3_key)
+
+        try:
+            # Update Lambda using S3
             cprint("Updating lambda function code", 'yellow')
             response = client.update_function_code(
                 FunctionName=name,
-                ZipFile=file_bytes
+                S3Bucket=bucket_name,
+                S3Key=s3_key
             )
-            
-            time.sleep(15)
-
+            time.sleep(5)
             cprint("Updating lambda function configuration", 'yellow')
             response = client.update_function_configuration(
                 FunctionName=name,
                 **options
             )
-        except ClientError as e:
-            if e.response['Error']['Code'] == 'ResourceNotFoundException':
-                response = client.create_function(
-                    FunctionName=name,
-                    Code={'ZipFile': file_bytes},
-                    **options
-                )
-            else:
-                raise e
+        except client.exceptions.ResourceNotFoundException:
+            response = client.create_function(
+                FunctionName=name,
+                Code={'S3Bucket': bucket_name, 'S3Key': s3_key},
+                **options
+            )
         return response['FunctionName'], response['FunctionArn']
     return name, "DRYRUN"