Merge pull request #40 from bamlab/fix/opening-keyboard-should-not-remove-top-padding

P0labrD · web-flow · commit d5a4e89c94d6 · 2025-10-10T12:18:46.000+02:00
fix: viewInsets should not be updated on keyboard open/close
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.10.1
+
+* fix: revert viewPadding update when keyboard opens/closes.
+
 ## 0.10.0
 
 * feat: Add support for 2-button and 3-button navigation for Android devices.
diff --git a/lib/src/adaptive/window_configuration_tester.dart b/lib/src/adaptive/window_configuration_tester.dart
@@ -23,13 +23,11 @@ extension WidgetTesterWithConfigurableWindow on WidgetTester {
   void configureOpenedKeyboardWindow(WindowConfigData windowConfig) {
     view.viewInsets = windowConfig.viewInsets;
     view.padding = windowConfig.padding.copyWith(bottom: 0);
-    view.viewPadding = windowConfig.viewInsets;
   }
 
   /// Configure the tester window to represent a closed keyboard on the given device variant.
   void configureClosedKeyboardWindow(WindowConfigData windowConfig) {
     view.resetViewInsets();
     view.padding = windowConfig.padding;
-    view.viewPadding = windowConfig.padding;
   }
 }
diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,7 +1,7 @@
 name: adaptive_test
 description: >-
   A Flutter package to generate adaptive golden files during widget tests.
-version: 0.10.0
+version: 0.10.1
 homepage: https://github.com/bamlab/adaptive_test
 repository: https://github.com/bamlab/adaptive_test
 

Original file line number	Diff line number	Diff line change
`@@ -23,13 +23,11 @@ extension WidgetTesterWithConfigurableWindow on WidgetTester {`
`23`	`23`	`void configureOpenedKeyboardWindow(WindowConfigData windowConfig) {`
`24`	`24`	`view.viewInsets = windowConfig.viewInsets;`
`25`	`25`	`view.padding = windowConfig.padding.copyWith(bottom: 0);`
`26`		`- view.viewPadding = windowConfig.viewInsets;`
`27`	`26`	`}`
`28`	`27`
`29`	`28`	`/// Configure the tester window to represent a closed keyboard on the given device variant.`
`30`	`29`	`void configureClosedKeyboardWindow(WindowConfigData windowConfig) {`
`31`	`30`	`view.resetViewInsets();`
`32`	`31`	`view.padding = windowConfig.padding;`
`33`		`- view.viewPadding = windowConfig.padding;`
`34`	`32`	`}`
`35`	`33`	`}`