Skip to content

Commit 0649f16

Browse files
committed
fix all
1 parent 8be48d6 commit 0649f16

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/build_wheels.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@ on:
1515

1616
jobs:
1717
build_linux_amd64:
18-
if: true
18+
if: true # require -dynamic-link=True in gopy build
1919
name: Build Linux Amd64
20-
runs-on: ubuntu-22.04
20+
runs-on: ubuntu-latest
2121
steps:
2222
- name: Checkout code
2323
uses: actions/checkout@v4
@@ -59,7 +59,7 @@ jobs:
5959
path: ./wheelhouse/*.whl
6060

6161
build_linux_arm:
62-
if: true
62+
if: true # require -dynamic-link=True in gopy build
6363
name: Build Linux (aarch64)
6464
runs-on: ubuntu-latest
6565

@@ -155,7 +155,7 @@ jobs:
155155
path: ./wheelhouse/*.whl
156156

157157
build_wheels_windows:
158-
if: true
158+
if: true # must remove -dynamic-link=True in gopy build
159159
name: Build wheels on Windows
160160
runs-on: windows-2019
161161
# strategy:

python/setup_custom.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,19 @@ def build_extension(self, ext: setuptools.Extension):
4747
"gopy",
4848
"build",
4949
"-no-make",
50-
"-dynamic-link=True",
50+
]
51+
if platform.system() != "Windows":
52+
cmd.append("-dynamic-link=True")
53+
54+
cmd.extend([
5155
"-output",
5256
pkg_dir,
5357
"-name",
5458
pkg_name,
5559
"-vm",
5660
py_executable,
5761
"-rename=true",
58-
]
62+
])
5963
cmd.extend(go_packages)
6064

6165
print(f"--- Compiling Go packages using gopy: {' '.join(cmd)} ---", flush=True)

0 commit comments

Comments
 (0)