remove as conversion and refactor

Author: colmazia

packages/kit/src/ext/cmp.rs

@@ -6,7 +6,7 @@ pub fn fcmp<T>(lhs: &T, rhs: &T) -> Ordering
 where
     T: Float,
 {
-    match lhs.partial_cmp(&rhs) {
+    match lhs.partial_cmp(rhs) {
         Some(ordering) => ordering,
         None => {
             if lhs.is_nan() {

packages/kit/src/ext/stats.rs

@@ -25,7 +25,7 @@ where
     T: Num,
     F: FnMut(&T, &T) -> Ordering,
 {
-    if data.len() == 0 {
+    if data.is_empty() {
         return None;
     }
     data.sort_by(compare);
@@ -60,9 +60,9 @@ where
     // https://en.wikipedia.org/wiki/Boyer%E2%80%93Moore_majority_vote_algorithm
     for idx in 1..len {
         if data[candidate] == data[idx] {
-            count = count + 1;
+            count += 1;
         } else {
-            count = count - 1;
+            count -= 1;
         }
         if count == 0 {
             candidate = idx;
@@ -73,7 +73,7 @@ where
     count = 0;
     for idx in 0..len {
         if data[candidate] == data[idx] {
-            count = count + 1;
+            count += 1;
         }
     }
 

packages/vm/src/cache.rs

@@ -25,7 +25,7 @@ impl InMemoryCache {
 
     /// Looks up a module in the cache and creates a new module
     pub fn load(&mut self, checksum: &Checksum) -> Option<Module> {
-        self.modules.get(checksum).map(|m| m.clone())
+        self.modules.get(checksum).cloned()
     }
 }
 

packages/vm/src/calls.rs

@@ -37,7 +37,7 @@ where
 
     function.call().map_err(|runtime_err| {
         if let Ok(err) = runtime_err.downcast::<Error>() {
-            return err.clone();
+            return err;
         }
 
         match get_remaining_points(&instance) {

packages/vm/src/error.rs

@@ -24,6 +24,7 @@ pub enum Error {
     UninitializedContextData = 15, // Error while getting uninitialized context data.
     ChecksumLengthNotMatch = 16, // Checksum not of intended length.
     DataLengthOutOfBound = 17, // Data length is out of bound.
+    ConvertTypeOutOfBound = 18, // Error while try to convert type.
     // Host-generated errors while interacting with OEI.
     WrongPeriodActionError = 128, // OEI action to invoke is not available.
     TooManyExternalDataError = 129, // Too many external data requests.
@@ -39,6 +40,6 @@ pub enum Error {
 impl std::error::Error for Error {}
 impl Display for Error {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(f, "{}", self)
+        write!(f, "{:?}", self)
     }
 }