core: apply envelope gas limit policy to txpool and state transition

Author: txhsl

core/state_transition.go

@@ -330,6 +330,11 @@ func (st *StateTransition) preCheck() error {
 			if st.evm.ChainConfig().DBFT != nil {
 				var minGasTipCap = st.state.GetState(systemcontracts.PolicyProxyHash, systemcontracts.GetMinGasTipCapStateHash()).Big()
 				if antimev.IsEnvelopeToAddress(msg.To) && antimev.IsEnvelopeData(msg.Data) {
+					var envelopeGasLimit = st.state.GetState(systemcontracts.PolicyProxyHash, systemcontracts.GetMaxEnvelopeGasLimitStateHash()).Big()
+					if new(big.Int).SetUint64(msg.GasLimit).Cmp(envelopeGasLimit) > 0 {
+						return fmt.Errorf("%w: address %v, gasLimit %v, policy maxEnvelopeGasLimit %v, ", ErrGasLimitReached, msg.From.Hex(), msg.GasLimit,
+							envelopeGasLimit)
+					}
 					var envelopeFee = st.state.GetState(systemcontracts.PolicyProxyHash, systemcontracts.GetEnvelopeFeeStateHash()).Big()
 					minGasTipCap.Add(minGasTipCap, envelopeFee)
 				}

core/systemcontracts/contracts.go

@@ -25,6 +25,7 @@ const blackListSlotIndex = 1
 const minGasTipCapSlotIndex = 2
 const baseFeeSlotIndex = 3
 const envelopeFeeSlotIndex = 5
+const maxEnvelopeGasLimitSlotIndex = 7
 
 // A set of genesis contract hashes.
 var (
@@ -102,3 +103,10 @@ func GetBlackListStateHash(addr common.Address) common.Hash {
 func GetEnvelopeFeeStateHash() common.Hash {
 	return common.BytesToHash([]byte{envelopeFeeSlotIndex})
 }
+
+// GetMaxEnvelopeGasLimitStateHash computes and returns the storage key
+// of maxEnvelopeGasLimit in policy contract, for reading corresponding
+// values from statedb.
+func GetMaxEnvelopeGasLimitStateHash() common.Hash {
+	return common.BytesToHash([]byte{maxEnvelopeGasLimitSlotIndex})
+}

core/txpool/validation.go

@@ -216,8 +216,13 @@ func ValidateTransactionWithState(tx *types.Transaction, signer types.Signer, op
 	// For LegacyTx, GasFeeCap and GasPrice are equal, so checking GasTipCap and GasFeeCap is enough
 	var minGasTipCap = opts.State.GetState(systemcontracts.PolicyProxyHash, systemcontracts.GetMinGasTipCapStateHash()).Big()
 	var baseFee = opts.State.GetState(systemcontracts.PolicyProxyHash, systemcontracts.GetBaseFeeStateHash()).Big()
-	// Apply policy envelope fee check
+	// Apply policy envelope check
 	if antimev.IsEnvelope(tx) {
+		var envelopeGasLimit = opts.State.GetState(systemcontracts.PolicyProxyHash, systemcontracts.GetMaxEnvelopeGasLimitStateHash()).Big()
+		if new(big.Int).SetUint64(tx.Gas()).Cmp(envelopeGasLimit) > 0 {
+			return fmt.Errorf("%w: policy maxEnvelopeGasLimit allowed %v, gas %v", ErrGasLimit, envelopeGasLimit, tx.Gas())
+		}
+		// Add envelope fee on top of minGasTipCap check
 		var envelopeFee = opts.State.GetState(systemcontracts.PolicyProxyHash, systemcontracts.GetEnvelopeFeeStateHash()).Big()
 		minGasTipCap.Add(minGasTipCap, envelopeFee)
 	}