dbft: close the pool once the check is finished

It has some goroutines spawned during Init and they keep the reference to pool
which can affect memory consumption given that we create these pools just for
temporary checks.

Signed-off-by: Roman Khimov <[email protected]>

Author: roman-khimov

consensus/dbft/dbft.go

@@ -858,6 +858,7 @@ func (c *DBFT) verifyPreBlockCb(b dbft.PreBlock[common.Hash]) bool {
 	ethBlock := dbftBlock.ToEthBlock()
 
 	localPool := c.newLocalPool(parent)
+	defer localPool.CloseSilently()
 	errs := localPool.Add(dbftBlock.transactions, false, false)
 	for i, err := range errs {
 		if err != nil {
@@ -1093,6 +1094,7 @@ func (c *DBFT) processPreBlockCb(b dbft.PreBlock[common.Hash]) error {
 				return true
 			}
 		)
+		defer localPool.CloseSilently()
 		for i := range pre.transactions {
 			var isEnvelope = j < len(pre.envelopesData) && pre.envelopesData[j].index == i
 			if !isEnvelope || // pre.transactions[i] is not an envelope, use it as-is.

core/txpool/legacypool/legacypool.go

@@ -475,15 +475,21 @@ func (pool *LegacyPool) loop() {
 	}
 }
 
-// Close terminates the transaction pool.
-func (pool *LegacyPool) Close() error {
+// CloseSilently is the same as Close(), but doesn't log. Intended to be used
+// for short-lived verification pools (not the main node tx pool).
+func (pool *LegacyPool) CloseSilently() {
 	// Terminate the pool reorger and return
 	close(pool.reorgShutdownCh)
 	pool.wg.Wait()
 
 	if pool.journal != nil {
 		pool.journal.close()
 	}
+}
+
+// Close terminates the transaction pool.
+func (pool *LegacyPool) Close() error {
+	pool.CloseSilently()
 	log.Info("Transaction pool stopped")
 	return nil
 }