Always use Policy-based block BaseFee

[AnnaShaleva]

Rationale

f06dad4 (#328) removes NeoXBurn fork and makes block's BaseFee to be Policy-based for dBFT-enabled nodes. However, nodes with another consensus engine still use an old-fashioned London way of BaseFee calculation.

Implementation

Always use Policy-based fee calculation behaviour irrespectively of consensus engine settings. It allows to get rid of some useless code that is never invoked in NeoX. Pitfalls: a lot of tests should be migrated onto new BaseFee calculation scheme or disabled.

[roman-khimov]

It's OK for us, NeoX does not have any other consensus mechanism.

[AnnaShaleva]

Yes, I know it’s OK, but it requires unit-tests rework, that’s why I moved it to a separate issue.

[txhsl]

I tried to run a full test of Geth, and got the following failures.

--- FAIL: TestGenerateEncryptedTx (7.74s)
    tpke_test.go:151: 
        	Error Trace:	/home/linux/Desktop/Bane/go-ethereum/antimev/tpke_test.go:151
        	Error:      	Received unexpected error:
        	            	no global public key
        	Test:       	TestGenerateEncryptedTx
FAIL

......

--- FAIL: TestUnderpricingDynamicFee (0.10s)
    legacypool_test.go:1977: adding underpriced pending transaction error mismatch: have <nil>, want transaction underpriced
--- FAIL: TestUnderpricing (0.08s)
    legacypool_test.go:1796: adding underpriced pending transaction error mismatch: have <nil>, want transaction underpriced
--- FAIL: TestDualHeapEviction (0.15s)
    legacypool_test.go:2070: transaction count mismatch: have 30, want 10
FAIL

Yes, we need to fix them. But, hmm, if the contract storage of the test chain is empty, then our fee policies should be all 0 so that not affecting the test results, so we don't need to rework them.

OK, so these UT failures are #316 and #372 related, since #316 increased the number of slots.

go-ethereum/core/txpool/legacypool/legacypool.go

Lines 810 to 830 in 28a4058

	if uint64(pool.all.Slots()+numSlots(tx)) > pool.config.GlobalSlots+pool.config.GlobalSlots+pool.config.GlobalQueue {
	// If the new transaction is underpriced, don't accept it
	if !isLocal && pool.priced.Underpriced(tx) {
	log.Trace("Discarding underpriced transaction", "hash", hash, "gasTipCap", tx.GasTipCap(), "gasFeeCap", tx.GasFeeCap())
	underpricedTxMeter.Mark(1)
	return false, txpool.ErrUnderpriced
	}
	// We're about to replace a transaction. The reorg does a more thorough
	// analysis of what to remove and how, but it runs async. We don't want to
	// do too many replacements between reorg-runs, so we cap the number of
	// replacements to 25% of the slots
	if pool.changesSinceReorg > int(pool.config.GlobalSlots/4) {
	throttleTxMeter.Mark(1)
	return false, ErrTxPoolOverflow
	}
	// New transaction is better than our worse ones, make room for it.
	// If it's a local transaction, forcibly discard all available transactions.
	// Otherwise if we can't make enough room for new one, abort the operation.
	drop, success := pool.priced.Discard(pool.all.Slots()-int(pool.config.GlobalSlots+pool.config.GlobalSlots+pool.config.GlobalQueue)+numSlots(tx), isLocal)