Incorrect legacy pool metrics caused by dBFT preblock handling #465
Description
System information
Geth version: v0.3.2
OS & Version: Windows/Linux/OSX
Expected behaviour
The original Geth code has only one LegacyPool implementation, and it uses go-metrics for monitoring. About it's usage, ref https://github.com/bane-labs/go-ethereum/tree/bane-main/metrics#readme.
Actual behaviour
This is not a critical problem, only about metrics data.
Since we are creating new LegacyPool instances in dBFT for transaction verification, additional metrics data are also counted unexpectedly. Different pool instance share the same metrics register, and their data get merged into the result of the real txpool. This leads to a different behavior when comparing to its original proposal.
This issue starts from #339. Further, we still need to face this issue in #341 and maybe #372.