WIP: Persist and prune blob data correctly #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Rebased to bane-main. |
txhsl
reviewed
Nov 11, 2025
|
|
||
| // ProtocolName is the official short name of the `neox` protocol used during | ||
| // devp2p capability negotiation. | ||
| const ProtocolName = "neox" |
Contributor
There was a problem hiding this comment.
Name it to blob or something similar, at least neox is not a good choice.
Collaborator
Author
There was a problem hiding this comment.
Since the block data message distribution will also be included in the neox protocol later, the name neox was chosen. It would be even better if there were other more preferable options.
txhsl
reviewed
Nov 11, 2025
| header.BlobGasUsed = new(uint64) | ||
| header.ParentBeaconRoot = new(common.Hash) | ||
|
|
||
| if cm.config.DBFT != nil { |
Contributor
There was a problem hiding this comment.
Can we not limit this to dBFT? I mean, a general handling will be better.
txhsl
reviewed
Nov 11, 2025
txhsl
reviewed
Nov 12, 2025
txhsl
reviewed
Nov 12, 2025
txhsl
reviewed
Nov 12, 2025
txhsl
reviewed
Nov 12, 2025
txhsl
reviewed
Nov 12, 2025
txhsl
reviewed
Nov 12, 2025
txhsl
reviewed
Nov 12, 2025
| ReceivedFrom interface{} | ||
|
|
||
| // sidecars provides DA check | ||
| sidecars BlobSidecars |
Contributor
There was a problem hiding this comment.
We have Payload defined in miner to carry this.
Contributor
|
@qianhh I've uploaded my proposal to https://github.com/bane-labs/go-ethereum/tree/blob-protocol. Just an idea, we need further development, but try to rebase onto it if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #520.
I will proceed with the following 3 steps to achieve it one by one.