Skip to content

Make Velero hook annotations configurable #658

@a-vorobiev

Description

@a-vorobiev

Preflight Checklist

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I agree to follow the Code of Conduct.

Problem Description

Currently Velero hook annotations use hardcoded path /vault/file for fsfreeze:

veleroAnnotations := map[string]string{
"pre.hook.backup.velero.io/container": "velero-fsfreeze",
"pre.hook.backup.velero.io/command": "[\"/sbin/fsfreeze\", \"--freeze\", \"/vault/file/\"]",
"post.hook.backup.velero.io/container": "velero-fsfreeze",
"post.hook.backup.velero.io/command": "[\"/sbin/fsfreeze\", \"--unfreeze\", \"/vault/file/\"]",
}

It is not possible to override these annotations with the vaultAnnotations, so there is no way to customize path for fsfreeze.

Proposed Solution

Make veleroAnnotations a part of custom resource with current value as a default.

Alternatives Considered

Get path from provided Vault configuration.

Additional Information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/enhancementCategorizes issue or PR as related to an improvement.lifecycle/keepDenotes an issue or PR that should be preserved from going stale.

    Type

    No type

    Projects

    Status

    🆕 New

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions