-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Labels
kind/enhancementCategorizes issue or PR as related to an improvement.Categorizes issue or PR as related to an improvement.lifecycle/keepDenotes an issue or PR that should be preserved from going stale.Denotes an issue or PR that should be preserved from going stale.
Description
Preflight Checklist
- I have searched the issue tracker for an issue that matches the one I want to file, without success.
- I agree to follow the Code of Conduct.
Problem Description
Currently Velero hook annotations use hardcoded path /vault/file for fsfreeze:
vault-operator/pkg/controller/vault/vault_controller.go
Lines 1417 to 1422 in 661263a
| veleroAnnotations := map[string]string{ | |
| "pre.hook.backup.velero.io/container": "velero-fsfreeze", | |
| "pre.hook.backup.velero.io/command": "[\"/sbin/fsfreeze\", \"--freeze\", \"/vault/file/\"]", | |
| "post.hook.backup.velero.io/container": "velero-fsfreeze", | |
| "post.hook.backup.velero.io/command": "[\"/sbin/fsfreeze\", \"--unfreeze\", \"/vault/file/\"]", | |
| } |
It is not possible to override these annotations with the vaultAnnotations, so there is no way to customize path for fsfreeze.
Proposed Solution
Make veleroAnnotations a part of custom resource with current value as a default.
Alternatives Considered
Get path from provided Vault configuration.
Additional Information
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/enhancementCategorizes issue or PR as related to an improvement.Categorizes issue or PR as related to an improvement.lifecycle/keepDenotes an issue or PR that should be preserved from going stale.Denotes an issue or PR that should be preserved from going stale.
Type
Projects
Status
🆕 New