fix: Optimize workload secrets version update logic in runReloader

thiago-boche · thiago-boche · commit e8983663ff69 · 2026-02-16T15:24:58.000+10:00
Signed-off-by: Thiago Boche &lt;38021019+thiago-boche@users.noreply.github.com&gt;
diff --git a/pkg/reloader/reloader.go b/pkg/reloader/reloader.go
@@ -73,9 +73,11 @@ func (c *Controller) runReloader(ctx context.Context) {
 
 					// Update stored version
 					c.trackingMutex.Lock()
-					for i := range c.workloadSecrets.GetWorkloadSecretsMap()[workload] {
-						if c.workloadSecrets.GetWorkloadSecretsMap()[workload][i].Path == currentSecretMetadata.Path {
-							c.workloadSecrets.GetWorkloadSecretsMap()[workload][i].KVVersion = currentInfo.Version
+					workloadSecretsMap := c.workloadSecrets.GetWorkloadSecretsMap()
+					secrets := workloadSecretsMap[workload]
+					for i := range secrets {
+						if secrets[i].Path == currentSecretMetadata.Path {
+							secrets[i].KVVersion = currentInfo.Version
 						}
 					}
 					c.trackingMutex.Unlock()

Original file line number	Diff line number	Diff line change
`@@ -73,9 +73,11 @@ func (c *Controller) runReloader(ctx context.Context) {`
`73`	`73`
`74`	`74`	`// Update stored version`
`75`	`75`	`c.trackingMutex.Lock()`
`76`		`- for i := range c.workloadSecrets.GetWorkloadSecretsMap()[workload] {`
`77`		`- if c.workloadSecrets.GetWorkloadSecretsMap()[workload][i].Path == currentSecretMetadata.Path {`
`78`		`- c.workloadSecrets.GetWorkloadSecretsMap()[workload][i].KVVersion = currentInfo.Version`
	`76`	`+ workloadSecretsMap := c.workloadSecrets.GetWorkloadSecretsMap()`
	`77`	`+ secrets := workloadSecretsMap[workload]`
	`78`	`+ for i := range secrets {`
	`79`	`+ if secrets[i].Path == currentSecretMetadata.Path {`
	`80`	`+ secrets[i].KVVersion = currentInfo.Version`
`79`	`81`	`}`
`80`	`82`	`}`
`81`	`83`	`c.trackingMutex.Unlock()`