Skip to content

Commit a337e4b

Browse files
committed
fix: errors in README
1 parent a082a97 commit a337e4b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

argo/workflow/README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ You should see a list of pods running with names prefixed with `workflow-control
3030

3131
### 3. Patch argo-server authentication
3232

33-
As reported on the official documentation: https://argo-workflows.readthedocs.io/en/latest/quick-start/#patch-argo-server-authentication
33+
As reported on the official documentation: <https://argo-workflows.readthedocs.io/en/latest/quick-start/#patch-argo-server-authentication>
3434

3535
The argo-server (and thus the UI) defaults to client authentication, which requires clients to provide their Kubernetes bearer token to authenticate. For more information, refer to the Argo Server Auth Mode documentation. We will switch the authentication mode to `server` so that we can bypass the UI login for now:
3636

@@ -65,6 +65,7 @@ This command adds `cluster-admin` clusterrole to `argo:argo-server` and `argo:de
6565
kubectl create clusterrolebinding argo-admin-server --clusterrole=cluster-admin --serviceaccount=argo:argo-server -n argo
6666
kubectl create clusterrolebinding argo-admin-default --clusterrole=cluster-admin --serviceaccount=argo:default -n argo
6767
```
68+
6869
> In production evironments it's strongly recommended to create a dedicated role to these service accounts allowing only required verbs on the resources managed by the workflows.
6970
7071
### 6. Prepare secrets required by the pipelines
@@ -130,7 +131,7 @@ To submit the CD pipeline, you can use the [official APIs](https://argo-workflow
130131
<ArgoWorkflow URL>/api/v1/workflows/{namespace}/submit
131132
```
132133

133-
Or, alternatively, you can submit the workflow using the UI:
134+
Alternatively, you can submit the workflow using the UI:
134135

135136
![Submit CD workflow via UI](images/3_cd_submit.png)
136137

0 commit comments

Comments
 (0)