Skip to content

Commit 221059e

Browse files
authored
Make LogRecord fields private and add getters for encapsulation (open-telemetry#2314)
1 parent d3ebef2 commit 221059e

File tree

1 file changed

+14
-24
lines changed

1 file changed

+14
-24
lines changed

src/layer.rs

Lines changed: 14 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -334,10 +334,10 @@ mod tests {
334334

335335
// Validate common fields
336336
assert_eq!(log.instrumentation.name(), "opentelemetry-appender-tracing");
337-
assert_eq!(log.record.severity_number, Some(Severity::Error));
337+
assert_eq!(log.record.severity_number(), Some(Severity::Error));
338338

339339
// Validate trace context is none.
340-
assert!(log.record.trace_context.is_none());
340+
assert!(log.record.trace_context().is_none());
341341

342342
// Validate attributes
343343
#[cfg(not(feature = "experimental_metadata_attributes"))]
@@ -428,25 +428,20 @@ mod tests {
428428

429429
// validate common fields.
430430
assert_eq!(log.instrumentation.name(), "opentelemetry-appender-tracing");
431-
assert_eq!(log.record.severity_number, Some(Severity::Error));
431+
assert_eq!(log.record.severity_number(), Some(Severity::Error));
432432

433433
// validate trace context.
434-
assert!(log.record.trace_context.is_some());
434+
assert!(log.record.trace_context().is_some());
435435
assert_eq!(
436-
log.record.trace_context.as_ref().unwrap().trace_id,
436+
log.record.trace_context().unwrap().trace_id,
437437
trace_id_expected
438438
);
439439
assert_eq!(
440-
log.record.trace_context.as_ref().unwrap().span_id,
440+
log.record.trace_context().unwrap().span_id,
441441
span_id_expected
442442
);
443443
assert_eq!(
444-
log.record
445-
.trace_context
446-
.as_ref()
447-
.unwrap()
448-
.trace_flags
449-
.unwrap(),
444+
log.record.trace_context().unwrap().trace_flags.unwrap(),
450445
TraceFlags::SAMPLED
451446
);
452447

@@ -526,10 +521,10 @@ mod tests {
526521

527522
// Validate common fields
528523
assert_eq!(log.instrumentation.name(), "opentelemetry-appender-tracing");
529-
assert_eq!(log.record.severity_number, Some(Severity::Error));
524+
assert_eq!(log.record.severity_number(), Some(Severity::Error));
530525

531526
// Validate trace context is none.
532-
assert!(log.record.trace_context.is_none());
527+
assert!(log.record.trace_context().is_none());
533528

534529
// Attributes can be polluted when we don't use this feature.
535530
#[cfg(feature = "experimental_metadata_attributes")]
@@ -605,25 +600,20 @@ mod tests {
605600

606601
// validate common fields.
607602
assert_eq!(log.instrumentation.name(), "opentelemetry-appender-tracing");
608-
assert_eq!(log.record.severity_number, Some(Severity::Error));
603+
assert_eq!(log.record.severity_number(), Some(Severity::Error));
609604

610605
// validate trace context.
611-
assert!(log.record.trace_context.is_some());
606+
assert!(log.record.trace_context().is_some());
612607
assert_eq!(
613-
log.record.trace_context.as_ref().unwrap().trace_id,
608+
log.record.trace_context().unwrap().trace_id,
614609
trace_id_expected
615610
);
616611
assert_eq!(
617-
log.record.trace_context.as_ref().unwrap().span_id,
612+
log.record.trace_context().unwrap().span_id,
618613
span_id_expected
619614
);
620615
assert_eq!(
621-
log.record
622-
.trace_context
623-
.as_ref()
624-
.unwrap()
625-
.trace_flags
626-
.unwrap(),
616+
log.record.trace_context().unwrap().trace_flags.unwrap(),
627617
TraceFlags::SAMPLED
628618
);
629619

0 commit comments

Comments
 (0)