Skip to content

Commit c859fe5

Browse files
miguelafsilva5danielRep
authored andcommitted
feat(missing-void): Add missing void argument to function prototypes
Signed-off-by: Miguel Silva <[email protected]>
1 parent b144116 commit c859fe5

File tree

33 files changed

+76
-76
lines changed

33 files changed

+76
-76
lines changed

ci

src/arch/armv8/aarch32/inc/arch/subarch/sysregs.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#ifndef __ASSEMBLER__
1212

1313
#define SYSREG_GEN_ACCESSORS(name, op1, crn, crm, op2) \
14-
static inline unsigned long sysreg_##name##_read() \
14+
static inline unsigned long sysreg_##name##_read(void) \
1515
{ \
1616
unsigned long _temp; \
1717
__asm__ volatile("mrc p15, " #op1 ", %0, " #crn ", " #crm ", %1\n\r" : "=r"(_temp) \
@@ -24,7 +24,7 @@
2424
}
2525

2626
#define SYSREG_GEN_ACCESSORS_BANKED(name, reg) \
27-
static inline unsigned long sysreg_##name##_read() \
27+
static inline unsigned long sysreg_##name##_read(void) \
2828
{ \
2929
unsigned long _temp; \
3030
__asm__ volatile("mrs %0, " XSTR(reg) "\n\r" : "=r"(_temp)); \
@@ -36,7 +36,7 @@
3636
}
3737

3838
#define SYSREG_GEN_ACCESSORS_64(reg, op1, crm) \
39-
static inline unsigned long long sysreg_##reg##_read() \
39+
static inline unsigned long long sysreg_##reg##_read(void) \
4040
{ \
4141
unsigned long long _temp, _tempH; \
4242
__asm__ volatile("mrrc p15, " #op1 ", %0, %1, " #crm "\n\r" : "=r"(_temp), "=r"(_tempH)); \
@@ -49,7 +49,7 @@
4949
}
5050

5151
#define SYSREG_GEN_ACCESSORS_MERGE(reg, reg1, reg2) \
52-
static inline unsigned long long sysreg_##reg##_read() \
52+
static inline unsigned long long sysreg_##reg##_read(void) \
5353
{ \
5454
return ((unsigned long long)sysreg_##reg2##_read() << 32) | sysreg_##reg1##_read(); \
5555
} \
@@ -154,12 +154,12 @@ static inline void arm_at_s12e1w(vaddr_t vaddr)
154154
__asm__ volatile("mcr p15, 0, %0, c7, c8, 5" ::"r"(vaddr)); // ats12nsopw
155155
}
156156

157-
static inline void arm_tlbi_alle2is()
157+
static inline void arm_tlbi_alle2is(void)
158158
{
159159
__asm__ volatile("mcr p15, 4, r0, c8, c7, 0");
160160
}
161161

162-
static inline void arm_tlbi_vmalls12e1is()
162+
static inline void arm_tlbi_vmalls12e1is(void)
163163
{
164164
__asm__ volatile("mcr p15, 0, r0, c8, c7, 0");
165165
}

src/arch/armv8/aarch64/inc/arch/subarch/sysregs.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
#ifndef __ASSEMBLER__
4848

4949
#define SYSREG_GEN_ACCESSORS_NAME(reg, name) \
50-
static inline unsigned long sysreg##reg##read() \
50+
static inline unsigned long sysreg##reg##read(void) \
5151
{ \
5252
unsigned long _temp; \
5353
__asm__ volatile("mrs %0, " XSTR(name) "\n\r" : "=r"(_temp)); \
@@ -138,12 +138,12 @@ static inline void arm_at_s12e1w(vaddr_t vaddr)
138138
__asm__ volatile("at s12e1w, %0" ::"r"(vaddr));
139139
}
140140

141-
static inline void arm_tlbi_alle2is()
141+
static inline void arm_tlbi_alle2is(void)
142142
{
143143
__asm__ volatile("tlbi alle2is");
144144
}
145145

146-
static inline void arm_tlbi_vmalls12e1is()
146+
static inline void arm_tlbi_vmalls12e1is(void)
147147
{
148148
__asm__ volatile("tlbi vmalls12e1is");
149149
}

src/arch/armv8/armv8-a/inc/arch/profile/cpu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ struct cpu_arch_profile {
1313
struct psci_off_state psci_off_state;
1414
};
1515

16-
static inline struct cpu* cpu()
16+
static inline struct cpu* cpu(void)
1717
{
1818
return (struct cpu*)BAO_CPU_BASE;
1919
}

src/arch/armv8/armv8-a/inc/arch/tlb.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ static inline void tlb_hyp_inv_va(vaddr_t va)
1818
ISB();
1919
}
2020

21-
static inline void tlb_hyp_inv_all()
21+
static inline void tlb_hyp_inv_all(void)
2222
{
2323
DSB(ish);
2424
arm_tlbi_alle2is();

src/arch/armv8/armv8-a/psci.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ static void psci_save_state(enum wakeup_reason wakeup_reason)
3636
gicc_save_state(&cpu()->arch.profile.psci_off_state.gicc_state);
3737
}
3838

39-
static void psci_restore_state()
39+
static void psci_restore_state(void)
4040
{
4141
/**
4242
* The majority of the state is already restored in assembly routine psci_boot_entry.
@@ -45,7 +45,7 @@ static void psci_restore_state()
4545
gicc_restore_state(&cpu()->arch.profile.psci_off_state.gicc_state);
4646
}
4747

48-
static void psci_wake_from_powerdown()
48+
static void psci_wake_from_powerdown(void)
4949
{
5050
if (cpu()->vcpu == NULL) {
5151
ERROR("cpu woke up but theres no vcpu to run");
@@ -56,7 +56,7 @@ static void psci_wake_from_powerdown()
5656
vcpu_run(cpu()->vcpu);
5757
}
5858

59-
static void psci_wake_from_idle()
59+
static void psci_wake_from_idle(void)
6060
{
6161
cpu_idle_wakeup();
6262
}

src/arch/armv8/armv8-a/smmuv2.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ inline streamid_t smmu_sme_get_mask(size_t sme)
7272
return SMMU_SMR_MASK(smmu.hw.glbl_rs0->SMR[sme]);
7373
}
7474

75-
static void smmu_check_features()
75+
static void smmu_check_features(void)
7676
{
7777
unsigned version =
7878
bit32_extract(smmu.hw.glbl_rs0->IDR7, SMMUV2_IDR7_MAJOR_OFF, SMMUV2_IDR7_MAJOR_LEN);

src/arch/armv8/armv8-r/inc/arch/mem.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ typedef union {
5252

5353
#define MPU_ARCH_MAX_NUM_ENTRIES (64)
5454

55-
static inline size_t mpu_granularity()
55+
static inline size_t mpu_granularity(void)
5656
{
5757
return (size_t)PAGE_SIZE;
5858
}

src/arch/armv8/armv8-r/inc/arch/profile/cpu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ struct cpu_arch_profile {
3838
} mpu;
3939
};
4040

41-
static inline struct cpu* cpu()
41+
static inline struct cpu* cpu(void)
4242
{
4343
return (struct cpu*)sysreg_tpidr_el2_read();
4444
}

src/arch/armv8/armv8-r/mpu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <arch/sysregs.h>
99
#include <arch/fences.h>
1010

11-
static inline size_t mpu_num_entries()
11+
static inline size_t mpu_num_entries(void)
1212
{
1313
return (size_t)MPUIR_REGION(sysreg_mpuir_el2_read());
1414
}
@@ -154,7 +154,7 @@ static inline mem_attrs_t mpu_entry_attrs(struct mp_region* mpr)
154154
return (mem_attrs_t)flags.raw;
155155
}
156156

157-
static mpid_t mpu_entry_allocate()
157+
static mpid_t mpu_entry_allocate(void)
158158
{
159159
mpid_t reg_num = INVALID_MPID;
160160
for (mpid_t i = 0; i < (mpid_t)mpu_num_entries(); i++) {

0 commit comments

Comments
 (0)