-
-
Notifications
You must be signed in to change notification settings - Fork 66
Open
Labels
bugSomething isn't workingSomething isn't working
Description
The following component:
<% form_layout.with_item do %>
<%= form.polaris_text_field(
:password,
label: t(".password_label"),
type: :password,
value: smtp_config.password.presence,
) %>
Leaks the password value in the data attributes added for Stimulus controller:
The form itself correctly masks the password value, but stimulus would also need to mask it for type: :password.
Note: The value must be passed explicitly for the dot dot dot mask to show up in browsers. When no value is set then the field looks empty, which is confusing as well.
I'll see if I can come up with a PR to fix the above.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working
