Skip to content

Commit 092217f

Browse files
authored
Easy-to-track silenced errors (#1564)
1 parent ee23335 commit 092217f

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

src/LaravelDebugbar.php

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -577,10 +577,15 @@ public function addCollector(DataCollectorInterface $collector)
577577
*/
578578
public function handleError($level, $message, $file = '', $line = 0, $context = [])
579579
{
580+
$exception = new \ErrorException($message, 0, $level, $file, $line);
580581
if (error_reporting() & $level) {
581-
throw new \ErrorException($message, 0, $level, $file, $line);
582-
} else {
583-
$this->addMessage($message, 'deprecation');
582+
throw $exception;
583+
}
584+
585+
$this->addThrowable($exception);
586+
if ($this->hasCollector('messages')) {
587+
$file = $file ? ' on ' . $this['messages']->normalizeFilePath($file) . ":{$line}" : '';
588+
$this['messages']->addMessage($message . $file, 'deprecation');
584589
}
585590
}
586591

src/Resources/laravel-debugbar.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -672,6 +672,11 @@ div.phpdebugbar-widgets-messages .phpdebugbar-widgets-value.phpdebugbar-widgets-
672672
color: #FF9800;
673673
}
674674

675+
div.phpdebugbar-widgets-messages li.phpdebugbar-widgets-list-item span.phpdebugbar-widgets-value.phpdebugbar-widgets-deprecation:before {
676+
content: "\f1f6";
677+
color: #FF9800;
678+
}
679+
675680
div.phpdebugbar-widgets-messages li.phpdebugbar-widgets-list-item pre.sf-dump {
676681
display: inline-block !important;
677682
position: relative;

0 commit comments

Comments
 (0)