Skip to content

Commit 3ad206c

Browse files
authored
Add (initial) support for PHP 8.4 (#1631)
* Run tests on PHP 8.4 * Update integration test to actually test clear command functionality
1 parent 423ee47 commit 3ad206c

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/run-integration-tests.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
COMPOSER_NO_INTERACTION: 1
1919
strategy:
2020
matrix:
21-
php: [8.3, 8.2, 8.1, 8.0]
21+
php: [8.4, 8.3, 8.2, 8.1, 8.0]
2222
lumen: [10.*, 9.*]
2323
exclude:
2424
- lumen: 10.*
@@ -54,10 +54,11 @@ jobs:
5454
- name: Execute clear run
5555
run: |
5656
cd sample
57+
mkdir -p "storage/debugbar/" && touch "storage/debugbar/foo.json"
5758
php artisan debugbar:clear
5859
- name: Check file count in logs
5960
run: |
60-
if [ `ls -1q "sample/storage/logs/" | wc -l` -gt 0 ];then exit 1;fi
61+
if [ `ls -1q "sample/storage/debugbar/" | wc -l` -gt 0 ];then exit 1;fi
6162
php-laravel-integration-tests:
6263
runs-on: ubuntu-latest
6364
timeout-minutes: 15
@@ -66,7 +67,7 @@ jobs:
6667
strategy:
6768
fail-fast: false
6869
matrix:
69-
php: [8.3, 8.2, 8.1, 8.0]
70+
php: [8.4, 8.3, 8.2, 8.1, 8.0]
7071
laravel: [11.*, 10.*, 9.*]
7172
exclude:
7273
- laravel: 10.*
@@ -103,7 +104,8 @@ jobs:
103104
- name: Execute generate run
104105
run: |
105106
cd sample
107+
mkdir -p "storage/debugbar/" && touch "storage/debugbar/foo.json"
106108
php artisan debugbar:clear
107109
- name: Check file count in logs
108110
run: |
109-
if [ `ls -1q "sample/storage/logs/" | wc -l` -gt 0 ];then exit 1;fi
111+
if [ `ls -1q "sample/storage/debugbar/" | wc -l` -gt 0 ];then exit 1;fi

.github/workflows/run-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
strategy:
2121
fail-fast: false
2222
matrix:
23-
php: [8.3, 8.2, 8.1, 8.0]
23+
php: [8.4, 8.3, 8.2, 8.1, 8.0]
2424
laravel: [^11, ^10, ^9]
2525
dependency-version: [prefer-stable]
2626
exclude:

0 commit comments

Comments
 (0)