Skip to content

Commit c643467

Browse files
committed
Add new cache events on CacheCollector
1 parent dff0932 commit c643467

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

src/DataCollector/CacheCollector.php

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,15 @@
44

55
use DebugBar\DataCollector\TimeDataCollector;
66
use DebugBar\DataFormatter\HasDataFormatter;
7-
use Illuminate\Cache\Events\CacheEvent;
8-
use Illuminate\Cache\Events\CacheHit;
9-
use Illuminate\Cache\Events\CacheMissed;
10-
use Illuminate\Cache\Events\KeyForgotten;
11-
use Illuminate\Cache\Events\KeyWritten;
7+
use Illuminate\Cache\Events\{
8+
CacheFlushed,
9+
CacheHit,
10+
CacheMissed,
11+
KeyForgetFailed,
12+
KeyForgotten,
13+
KeyWriteFailed,
14+
KeyWritten,
15+
};
1216
use Illuminate\Events\Dispatcher;
1317

1418
class CacheCollector extends TimeDataCollector
@@ -22,8 +26,11 @@ class CacheCollector extends TimeDataCollector
2226
protected $classMap = [
2327
CacheHit::class => 'hit',
2428
CacheMissed::class => 'missed',
29+
CacheFlushed::class => 'flushed',
2530
KeyWritten::class => 'written',
31+
KeyWriteFailed::class => 'write_failed',
2632
KeyForgotten::class => 'forgotten',
33+
KeyForgetFailed::class => 'forget_failed',
2734
];
2835

2936
public function __construct($requestStartTime, $collectValues)
@@ -33,7 +40,7 @@ public function __construct($requestStartTime, $collectValues)
3340
$this->collectValues = $collectValues;
3441
}
3542

36-
public function onCacheEvent(CacheEvent $event)
43+
public function onCacheEvent($event)
3744
{
3845
$class = get_class($event);
3946
$params = get_object_vars($event);
@@ -53,21 +60,20 @@ public function onCacheEvent(CacheEvent $event)
5360
}
5461

5562

56-
if (!empty($params['key']) && in_array($label, ['hit', 'written'])) {
63+
if (!empty($params['key'] ?? null) && in_array($label, ['hit', 'written'])) {
5764
$params['delete'] = route('debugbar.cache.delete', [
5865
'key' => urlencode($params['key']),
5966
'tags' => !empty($params['tags']) ? json_encode($params['tags']) : '',
6067
]);
6168
}
6269

6370
$time = microtime(true);
64-
$this->addMeasure($label . "\t" . $event->key, $time, $time, $params);
71+
$this->addMeasure($label . "\t" . ($params['key'] ?? ''), $time, $time, $params);
6572
}
6673

67-
6874
public function subscribe(Dispatcher $dispatcher)
6975
{
70-
foreach ($this->classMap as $eventClass => $type) {
76+
foreach (array_keys($this->classMap) as $eventClass) {
7177
$dispatcher->listen($eventClass, [$this, 'onCacheEvent']);
7278
}
7379
}

src/Resources/cache/widget.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@
4040
var m = lines[i];
4141

4242
if (measure.params && !$.isEmptyObject(measure.params)) {
43+
if (measure.params.delete) {
44+
$(m).next().find('td:contains(delete)').parent().remove();
45+
}
4346
if (measure.params.delete && measure.params.key) {
4447
$('<a />')
4548
.addClass(csscls('forget'))

0 commit comments

Comments
 (0)