From b14fce8208122db23c11dfc801c1ba52f1cf9df6 Mon Sep 17 00:00:00 2001 From: Jesper Noordsij Date: Tue, 9 Jul 2024 12:07:07 +0200 Subject: [PATCH 1/2] Run tests on PHP 8.4 --- .github/workflows/run-integration-tests.yml | 4 ++-- .github/workflows/run-tests.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-integration-tests.yml b/.github/workflows/run-integration-tests.yml index d89713e91..17cee359a 100644 --- a/.github/workflows/run-integration-tests.yml +++ b/.github/workflows/run-integration-tests.yml @@ -18,7 +18,7 @@ jobs: COMPOSER_NO_INTERACTION: 1 strategy: matrix: - php: [8.3, 8.2, 8.1, 8.0] + php: [8.4, 8.3, 8.2, 8.1, 8.0] lumen: [10.*, 9.*] exclude: - lumen: 10.* @@ -66,7 +66,7 @@ jobs: strategy: fail-fast: false matrix: - php: [8.3, 8.2, 8.1, 8.0] + php: [8.4, 8.3, 8.2, 8.1, 8.0] laravel: [11.*, 10.*, 9.*] exclude: - laravel: 10.* diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index c2af099fb..7e4ea4077 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -20,7 +20,7 @@ jobs: strategy: fail-fast: false matrix: - php: [8.3, 8.2, 8.1, 8.0] + php: [8.4, 8.3, 8.2, 8.1, 8.0] laravel: [^11, ^10, ^9] dependency-version: [prefer-stable] exclude: From e0e449a1aa2aae6d9f0fe7b70b62ed08f9fe1916 Mon Sep 17 00:00:00 2001 From: Jesper Noordsij Date: Thu, 26 Sep 2024 16:46:39 +0200 Subject: [PATCH 2/2] Update integration test to actually test clear command functionality --- .github/workflows/run-integration-tests.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-integration-tests.yml b/.github/workflows/run-integration-tests.yml index 17cee359a..8d8bfe91c 100644 --- a/.github/workflows/run-integration-tests.yml +++ b/.github/workflows/run-integration-tests.yml @@ -54,10 +54,11 @@ jobs: - name: Execute clear run run: | cd sample + mkdir -p "storage/debugbar/" && touch "storage/debugbar/foo.json" php artisan debugbar:clear - name: Check file count in logs run: | - if [ `ls -1q "sample/storage/logs/" | wc -l` -gt 0 ];then exit 1;fi + if [ `ls -1q "sample/storage/debugbar/" | wc -l` -gt 0 ];then exit 1;fi php-laravel-integration-tests: runs-on: ubuntu-latest timeout-minutes: 15 @@ -103,7 +104,8 @@ jobs: - name: Execute generate run run: | cd sample + mkdir -p "storage/debugbar/" && touch "storage/debugbar/foo.json" php artisan debugbar:clear - name: Check file count in logs run: | - if [ `ls -1q "sample/storage/logs/" | wc -l` -gt 0 ];then exit 1;fi + if [ `ls -1q "sample/storage/debugbar/" | wc -l` -gt 0 ];then exit 1;fi