unshift is better than rest

pataar · pataar · commit 8b4348a295c6 · 2024-10-28T21:12:34.000+01:00
diff --git a/src/Console/ModelsCommand.php b/src/Console/ModelsCommand.php
@@ -731,7 +731,7 @@ public function getPropertiesFromMethods($model)
                                             if ($existingPivot = ($this->properties[$relationObj->getPivotAccessor()] ?? null)) {
                                                 $existingClasses = explode('|', $existingPivot['type']);
                                                 if(!in_array($pivot, $existingClasses)) {
-                                                    $existingClasses = [$pivot, ...$existingClasses];
+                                                    array_unshift($existingClasses, $pivot);
                                                 }
                                             } else {
                                                 // No existing pivot property, so we need to add a null type

Original file line number	Diff line number	Diff line change
`@@ -731,7 +731,7 @@ public function getPropertiesFromMethods($model)`
`731`	`731`	`if ($existingPivot = ($this->properties[$relationObj->getPivotAccessor()] ?? null)) {`
`732`	`732`	`$existingClasses = explode('\|', $existingPivot['type']);`
`733`	`733`	`if(!in_array($pivot, $existingClasses)) {`
`734`		`- $existingClasses = [$pivot, ...$existingClasses];`
	`734`	`+ array_unshift($existingClasses, $pivot);`
`735`	`735`	`}`
`736`	`736`	`} else {`
`737`	`737`	`// No existing pivot property, so we need to add a null type`