Skip to content

replace switch case with assoc array #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace switch case with assoc array #1096

wants to merge 1 commit into from

Conversation

alirezavalipour
Copy link

Summary

replace switch case with assoc array

Type of change

  • replace switch case with assoc array, because it's less code lines and it's more understandable

@mfn
Copy link
Collaborator

mfn commented Nov 30, 2020

👎 on the whole change, I don't think it improves anything and actually it makes the first default branch harder to read and to maintain, should the logic need to be improved:
image

The last line looks so forced without much gain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alirezavalipour @mfn