Skip to content

add support for on, onWriteConnection, with on models #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for on, onWriteConnection, with on models #1260

wants to merge 1 commit into from

Conversation

Douglasdc3
Copy link

@Douglasdc3 Douglasdc3 commented Oct 1, 2021 •
edited
Loading

Summary

Add support to start query builder using on, onWriteConnection and with methods similar to the existing query method.

Resolves issues #1235

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Code style has been fixed via composer fix-style

mfn
mfn approved these changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@barryvdh IMHO loos good to merge from my side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Douglasdc3 @mfn