Skip to content

Commit cd152ab

Browse files
fixes in tests
1 parent 0e60ae3 commit cd152ab

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

src/django_elasticsearch_dsl_drf/tests/test_ordering_common.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,10 @@ def setUpClass(cls):
109109
cls.backend = OrderingFilterBackend()
110110
cls.view = BookDocumentViewSet()
111111

112-
def _order_by_field(self, field_name, url, check_ordering=True,
112+
def _order_by_field(self,
113+
field_name,
114+
url,
115+
check_ordering=True,
113116
nested_resp_key=None):
114117
"""Order by field.
115118
@@ -266,10 +269,14 @@ def test_book_order_by_non_existent_field(self):
266269
check_ordering=False)
267270

268271
def test_address_default_order_by(self):
272+
"""Test if default ordering on addresses is correct (asc)."""
269273
return self._order_by_default_field('id', self.addresses_url)
270274

271-
def test_address_default_order_by_descending(self):
272-
return self._order_by_default_field('-id', self.addresses_url)
275+
# def test_address_default_order_by_descending(self):
276+
# """Test if default ordering on ??? is correct (desc)."""
277+
# # TODO: Define an endpoint where default ordering would be
278+
# # desc and test on that.
279+
# return self._order_by_default_field('-id', self.addresses_url)
273280

274281
def test_address_default_nested_order_by(self):
275282
return self._order_by_default_field('city.name', self.addresses_url,

0 commit comments

Comments
 (0)