Merge pull request valkey-io#2847 from valkey-io/go-command-hincrby

GO: Add `HINCRBY` command

Author: prateek-kumar-improving

CHANGELOG.md

@@ -1,4 +1,5 @@
 #### Changes
+* Go: Add HINCRBY command ([#2847](https://github.com/valkey-io/valkey-glide/pull/2847))
 * Go: Add HINCRBYFLOAT command ([#2846](https://github.com/valkey-io/valkey-glide/pull/2846))
 * Go: Add SUNIONSTORE command ([#2805](https://github.com/valkey-io/valkey-glide/pull/2805))
 * Go: Add SUNION ([#2787](https://github.com/valkey-io/valkey-glide/pull/2787))

go/api/base_client.go

@@ -441,6 +441,15 @@ func (client *baseClient) HStrLen(key string, field string) (Result[int64], erro
 	return handleLongResponse(result)
 }
 
+func (client *baseClient) HIncrBy(key string, field string, increment int64) (Result[int64], error) {
+	result, err := client.executeCommand(C.HIncrBy, []string{key, field, utils.IntToString(increment)})
+	if err != nil {
+		return CreateNilInt64Result(), err
+	}
+
+	return handleLongResponse(result)
+}
+
 func (client *baseClient) HIncrByFloat(key string, field string, increment float64) (Result[float64], error) {
 	result, err := client.executeCommand(C.HIncrByFloat, []string{key, field, utils.FloatToString(increment)})
 	if err != nil {

go/api/commands.go

@@ -705,8 +705,30 @@ type HashCommands interface {
 	// [valkey.io]: https://valkey.io/commands/hstrlen/
 	HStrLen(key string, field string) (Result[int64], error)
 
+	// Increments the number stored at `field` in the hash stored at `key` by increment.
+	// By using a negative increment value, the value stored at `field` in the hash stored at `key` is decremented.
+	// If `field` or `key` does not exist, it is set to 0 before performing the operation.
+	//
+	// See [valkey.io] for details.
+	//
+	// Parameters:
+	// 	key - The key of the hash.
+	// 	field - The field in the hash stored at `key` to increment its value.
+	// 	increment - The amount to increment.
+	//
+	// Return value:
+	// 	The Result[int64] value of `field` in the hash stored at `key` after the increment.
+	//
+	// Example:
+	//  _, err := client.HSet("key", map[string]string{"field": "10"})
+	//  hincrByResult, err := client.HIncrBy("key", "field", 1)
+	//	// hincrByResult.Value(): 11
+	//
+	// [valkey.io]: https://valkey.io/commands/hincrby/
+	HIncrBy(key string, field string, increment int64) (Result[int64], error)
+
 	// Increments the string representing a floating point number stored at `field` in the hash stored at `key` by increment.
-	// By using a negative increment value, the value stored at field in the hash stored at `key` is decremented.
+	// By using a negative increment value, the value stored at `field` in the hash stored at `key` is decremented.
 	// If `field` or `key` does not exist, it is set to 0 before performing the operation.
 	//
 	// See [valkey.io] for details.
@@ -720,7 +742,7 @@ type HashCommands interface {
 	// 	The Result[float64] value of `field` in the hash stored at `key` after the increment.
 	//
 	// Example:
-	//  hsetResult, err := client.HSet("key", map[string]string{"field": "10"})
+	//  _, err := client.HSet("key", map[string]string{"field": "10"})
 	//  hincrByFloatResult, err := client.HIncrByFloat("key", "field", 1.5)
 	//	// hincrByFloatResult.Value(): 11.5
 	//

go/integTest/shared_commands_test.go

@@ -1040,6 +1040,39 @@ func (suite *GlideTestSuite) TestHStrLen_WithNotExistingField() {
 	})
 }
 
+func (suite *GlideTestSuite) TestHIncrBy_WithExistingField() {
+	suite.runWithDefaultClients(func(client api.BaseClient) {
+		key := uuid.NewString()
+		field := uuid.NewString()
+		fieldValueMap := map[string]string{field: "10"}
+
+		hsetResult, err := client.HSet(key, fieldValueMap)
+		assert.Nil(suite.T(), err)
+		assert.Equal(suite.T(), int64(1), hsetResult.Value())
+
+		hincrByResult, hincrByErr := client.HIncrBy(key, field, 1)
+		assert.Nil(suite.T(), hincrByErr)
+		assert.Equal(suite.T(), int64(11), hincrByResult.Value())
+	})
+}
+
+func (suite *GlideTestSuite) TestHIncrBy_WithNonExistingField() {
+	suite.runWithDefaultClients(func(client api.BaseClient) {
+		key := uuid.NewString()
+		field := uuid.NewString()
+		field2 := uuid.NewString()
+		fieldValueMap := map[string]string{field2: "1"}
+
+		hsetResult, err := client.HSet(key, fieldValueMap)
+		assert.Nil(suite.T(), err)
+		assert.Equal(suite.T(), int64(1), hsetResult.Value())
+
+		hincrByResult, hincrByErr := client.HIncrBy(key, field, 2)
+		assert.Nil(suite.T(), hincrByErr)
+		assert.Equal(suite.T(), int64(2), hincrByResult.Value())
+	})
+}
+
 func (suite *GlideTestSuite) TestHIncrByFloat_WithExistingField() {
 	suite.runWithDefaultClients(func(client api.BaseClient) {
 		key := uuid.NewString()