Fix clippy warnings and apply nightly fmt

- Add missing doc comments for bundle state clone metrics
- Remove unused crate dependencies (alloy-sol-types, op-alloy-consensus, revm)
- Fix collapsible_if lint in flashblock_trie_cache.rs
- Add Debug derive to MeteringApiImpl
- Export MeterBundleOutput from public API

Author: niran

Cargo.lock

@@ -57,9 +57,11 @@ pub struct Metrics {
     #[metric(describe = "Total number of WebSocket reconnection attempts")]
     pub reconnect_attempts: Counter,
 
+    /// Time taken to clone bundle state.
     #[metric(describe = "Time taken to clone bundle state")]
     pub bundle_state_clone_duration: Histogram,
 
+    /// Size of bundle state being cloned (number of accounts).
     #[metric(describe = "Size of bundle state being cloned (number of accounts)")]
     pub bundle_state_clone_size: Histogram,
 }

crates/flashblocks/src/metrics.rs

@@ -35,10 +35,8 @@ alloy-consensus.workspace = true
 alloy-eips.workspace = true
 alloy-rpc-types.workspace = true
 alloy-rpc-types-eth.workspace = true
-alloy-sol-types.workspace = true
 
 # op-alloy
-op-alloy-consensus.workspace = true
 op-alloy-rpc-types.workspace = true
 op-alloy-network.workspace = true
 
@@ -47,7 +45,6 @@ tokio.workspace = true
 tokio-stream.workspace = true
 
 # revm
-revm.workspace = true
 revm-database.workspace = true
 
 # rpc

crates/rpc/Cargo.toml

@@ -16,7 +16,9 @@ use crate::FlashblocksState;
 /// each bundle's state root time reflects only its own I/O cost.
 #[derive(Debug, Clone)]
 pub struct FlashblockTrieData {
+    /// The trie updates from computing the state root.
     pub trie_updates: TrieUpdates,
+    /// The hashed post state used for state root computation.
     pub hashed_state: HashedPostState,
 }
 
@@ -61,10 +63,11 @@ impl FlashblockTrieCache {
         canonical_state_provider: &dyn StateProvider,
     ) -> EyreResult<FlashblockTrieData> {
         let cached_entry = self.cache.load();
-        if let Some(cached) = cached_entry.as_ref() {
-            if cached.block_hash == block_hash && cached.flashblock_index == flashblock_index {
-                return Ok(cached.trie_data.clone());
-            }
+        if let Some(cached) = cached_entry.as_ref()
+            && cached.block_hash == block_hash
+            && cached.flashblock_index == flashblock_index
+        {
+            return Ok(cached.trie_data.clone());
         }
 
         let hashed_state =

crates/rpc/src/base/flashblock_trie_cache.rs

@@ -13,7 +13,8 @@ use tracing::{error, info};
 
 use crate::{FlashblockTrieCache, MeteringApiServer, meter_bundle};
 
-/// Implementation of the metering RPC API
+/// Implementation of the metering RPC API.
+#[derive(Debug)]
 pub struct MeteringApiImpl<Provider, FB> {
     provider: Provider,
     flashblocks_state: Arc<FB>,

crates/rpc/src/base/meter_rpc.rs

@@ -9,7 +9,7 @@ pub use tips_core::types::{Bundle, MeterBundleResponse, TransactionResult};
 mod base;
 pub use base::{
     flashblock_trie_cache::{FlashblockTrieCache, FlashblockTrieData},
-    meter::{FlashblocksState, meter_bundle},
+    meter::{FlashblocksState, MeterBundleOutput, meter_bundle},
     meter_rpc::MeteringApiImpl,
     pubsub::{EthPubSub, EthPubSubApiServer},
     traits::{MeteringApiServer, TransactionStatusApiServer},

crates/rpc/src/lib.rs

@@ -74,8 +74,7 @@ impl BaseNodeExtension for BaseRpcExtension {
                 // Metering API requires flashblocks state to access pending blocks for bundle simulation
                 if metering_enabled {
                     info!(message = "Starting Metering RPC");
-                    let metering_api =
-                        MeteringApiImpl::new(ctx.provider().clone(), fb.clone());
+                    let metering_api = MeteringApiImpl::new(ctx.provider().clone(), fb.clone());
                     ctx.modules.merge_configured(metering_api.into_rpc())?;
                 }