change if block order

JenabaBa · JenabaBa · commit 0c7d7f8d3963 · 2025-06-20T12:25:48.000-07:00
diff --git a/dependency_updater/dependency_updater.go b/dependency_updater/dependency_updater.go
@@ -143,9 +143,7 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
 		if dependencies[dependencyType].TagPrefix == "" {
 			version = releases[0]
 			break
-		} else if resp.NextPage == 0 {
-			break
-		} else {
+		} else if dependencies[dependencyType].TagPrefix != ""{
 			for release := range releases {
 				if strings.HasPrefix(*releases[release].TagName, dependencies[dependencyType].TagPrefix) {
 					version = releases[release]
@@ -157,6 +155,8 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie
 				break
 			}
 			options.Page = resp.NextPage
+		} else if resp.NextPage == 0 {
+			break
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -143,9 +143,7 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie`
`143`	`143`	`if dependencies[dependencyType].TagPrefix == "" {`
`144`	`144`	`version = releases[0]`
`145`	`145`	`break`
`146`		`- } else if resp.NextPage == 0 {`
`147`		`- break`
`148`		`- } else {`
	`146`	`+ } else if dependencies[dependencyType].TagPrefix != ""{`
`149`	`147`	`for release := range releases {`
`150`	`148`	`if strings.HasPrefix(*releases[release].TagName, dependencies[dependencyType].TagPrefix) {`
`151`	`149`	`version = releases[release]`
`@@ -157,6 +155,8 @@ func getVersionAndCommit(ctx context.Context, client *github.Client, dependencie`
`157`	`155`	`break`
`158`	`156`	`}`
`159`	`157`	`options.Page = resp.NextPage`
	`158`	`+ } else if resp.NextPage == 0 {`
	`159`	`+ break`
`160`	`160`	`}`
`161`	`161`	`}`
`162`	`162`