Fix release preflight gaps from PR #140 review (#141)

* Add Ruby, Kotlin, and Swift version preflight checks to make release

The release target only verified Go and TypeScript version constants
before tagging, so a stale Ruby/Kotlin/Swift version would push a tag
and let the workflows fail after the fact. Check all five SDKs upfront.

* Reinstate Kotlin generated-code drift guard in release workflow

When the Kotlin release was extracted from test.yml into its own
workflow, the :generator:run + git diff check was dropped. Without it
a v* tag could publish a Kotlin artifact with stale generated sources.

Author: jeremy

.github/workflows/release-kotlin.yml

@@ -79,6 +79,16 @@ jobs:
       - name: Test
         run: ./gradlew :basecamp-sdk:check
 
+      - name: Check generated code drift
+        run: |
+          ./gradlew :generator:run --args="--openapi ../openapi.json --behavior ../behavior-model.json --output sdk/src/commonMain/kotlin/com/basecamp/sdk/generated"
+          if ! git diff --quiet -- sdk/src/commonMain/kotlin/com/basecamp/sdk/generated/; then
+            echo "::error::Generated Kotlin code is out of date. Run 'make kt-generate-services' and commit."
+            git diff --stat -- sdk/src/commonMain/kotlin/com/basecamp/sdk/generated/
+            exit 1
+          fi
+          echo "Generated code is up to date"
+
   publish:
     name: Publish to GitHub Packages
     needs: [smithy, test]

Makefile

@@ -143,6 +143,12 @@ endif
 		{ echo "ERROR: Go version does not match $(VERSION). Run 'make bump VERSION=$(VERSION)' first."; exit 1; }
 	@grep -q '"version": "$(VERSION)"' typescript/package.json || \
 		{ echo "ERROR: TypeScript version does not match $(VERSION). Run 'make bump VERSION=$(VERSION)' first."; exit 1; }
+	@grep -q 'VERSION = "$(VERSION)"' ruby/lib/basecamp/version.rb || \
+		{ echo "ERROR: Ruby version does not match $(VERSION). Run 'make bump VERSION=$(VERSION)' first."; exit 1; }
+	@grep -q 'const val VERSION = "$(VERSION)"' kotlin/sdk/src/commonMain/kotlin/com/basecamp/sdk/BasecampConfig.kt || \
+		{ echo "ERROR: Kotlin version does not match $(VERSION). Run 'make bump VERSION=$(VERSION)' first."; exit 1; }
+	@grep -q 'public static let version = "$(VERSION)"' swift/Sources/Basecamp/BasecampConfig.swift || \
+		{ echo "ERROR: Swift version does not match $(VERSION). Run 'make bump VERSION=$(VERSION)' first."; exit 1; }
 	@git diff --quiet && git diff --cached --quiet || \
 		{ echo "ERROR: Working tree has uncommitted changes. Commit first."; exit 1; }
 	git tag "v$(VERSION)"