Skip to content

Commit 06a3951

Browse files
authored
Merge pull request #1771 from basecamp/webhooks-layout
Fix layouts and backlinks
2 parents 4904dfb + 656bef4 commit 06a3951

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

app/views/webhooks/edit.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
</div>
77
<% end %>
88

9-
<article class="panel center txt-align-start" style="view-transition-name: <%= dom_id(@webhook) %>">
9+
<article class="panel panel--wide center txt-align-start" style="view-transition-name: <%= dom_id(@webhook) %>">
1010
<%= form_with model: @webhook, url: @webhook, method: :put, data: { controller: "form" }, html: { class: "flex flex-column gap" } do |form| %>
1111
<h2 class="txt-large margin-none">
1212
<%= form.text_field :name, required: true, autofocus: true, class: "input full-width", placeholder: "Name your Webhook…", data: { action: "keydown.esc@document->form#cancel" } %>

app/views/webhooks/index.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<h1 class="header__title"><%= @page_title %></h1>
99
<% end %>
1010

11-
<%= tag.section class: "panel shadow center webhooks" do %>
11+
<%= tag.section class: "panel panel--wide shadow center webhooks" do %>
1212
<% if @page.records.any? %>
1313
<ul class="flex flex-column align-start gap margin-none-block-start unpad webhooks-list">
1414
<%= render partial: "webhooks/webhook", collection: @page.records %>

app/views/webhooks/new.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22

33
<% content_for :header do %>
44
<div class="header__actions header__actions--start">
5-
<%= link_back_to_board(@board) %>
5+
<%= back_link_to "Webhooks", board_webhooks_path, "keydown.left@document->hotkey#click" %>
66
</div>
77

88
<h1 class="header__title"><%= @page_title %></h1>
99
<% end %>
1010

11-
<article class="panel center txt-align-start" style="view-transition-name: <%= dom_id(@webhook) %>">
11+
<article class="panel panel--wide center txt-align-start" style="view-transition-name: <%= dom_id(@webhook) %>">
1212
<%= form_with model: @webhook, url: board_webhooks_path, data: { controller: "form" }, html: { class: "flex flex-column gap" } do |form| %>
1313
<h2 class="txt-large margin-none">
1414
<%= form.text_field :name, required: true, autofocus: true, class: "input", placeholder: "Name this Webhook…", data: { action: "keydown.esc@document->form#cancel" } %>

app/views/webhooks/show.html.erb

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,9 @@
22

33
<% content_for :header do %>
44
<div class="header__actions header__actions--start">
5-
<%= link_to board_webhooks_path, class: "btn btn--back borderless txt-medium", data: { controller: "hotkey", action: "keydown.left@document->hotkey#click" } do %>
6-
<span class="overflow-ellipsis flex align-center">
7-
<%= icon_tag "arrow-left" %>
8-
<strong>Back to Webhooks</strong>
9-
<kbd class="txt-x-small margin-inline-start hide-on-touch">&larr;</kbd>
10-
</span>
11-
<% end %>
5+
<div class="header__actions header__actions--start">
6+
<%= back_link_to "Webhooks", board_webhooks_path, "keydown.left@document->hotkey#click" %>
7+
</div>
128
</div>
139

1410
<div class="header__actions header__actions--end">
@@ -19,7 +15,7 @@
1915
<div>
2016
<% end %>
2117

22-
<div class="panel shadow center flex flex-column gap txt-align-start">
18+
<div class="panel panel--wide shadow center flex flex-column gap txt-align-start">
2319
<header>
2420
<h1 class="txt-x-large margin-none"><%= @webhook.name %></h1>
2521
<span class="txt-medium txt-break"><%= @webhook.url %></span>

0 commit comments

Comments
 (0)