Only staff can access beta/staging

https://app.fizzy.do/5986089/cards/3208

Author: jorgemanrubia

app/controllers/concerns/authorization.rb

@@ -3,6 +3,7 @@ module Authorization
 
   included do
     before_action :ensure_can_access_account, if: -> { Current.account.present? && authenticated? }
+    before_action :ensure_only_staff_can_access_non_production_remote_environments
   end
 
   class_methods do
@@ -29,6 +30,10 @@ def ensure_can_access_account
       redirect_to session_menu_url(script_name: nil) if Current.user.blank? || !Current.user.active?
     end
 
+    def ensure_only_staff_can_access_non_production_remote_environments
+      head :forbidden unless Rails.env.local? || Rails.env.production? || Current.identity.staff?
+    end
+
     def redirect_existing_user
       redirect_to root_path if Current.user
     end

test/controllers/non_production_remote_access_test.rb

@@ -0,0 +1,37 @@
+require "test_helper"
+
+class NonProductionRemoteAccessTest < ActionDispatch::IntegrationTest
+  test "staff can access in staging environment" do
+    sign_in_as :david
+
+    Rails.stub(:env, ActiveSupport::EnvironmentInquirer.new("staging")) do
+      get cards_path
+      assert_response :success
+    end
+  end
+
+  test "non-staff cannot access in staging environment" do
+    sign_in_as :jz
+
+    Rails.stub(:env, ActiveSupport::EnvironmentInquirer.new("staging")) do
+      get cards_path
+      assert_response :forbidden
+    end
+  end
+
+  test "non-staff can access in production environment" do
+    sign_in_as :jz
+
+    Rails.stub(:env, ActiveSupport::EnvironmentInquirer.new("production")) do
+      get cards_path
+      assert_response :success
+    end
+  end
+
+  test "non-staff can access in local environment" do
+    sign_in_as :jz
+
+    get cards_path
+    assert_response :success
+  end
+end