Skip to content

Commit 8ff5eb0

Browse files
committed
No need to indicate these, they're common
But show a tooltip all the same
1 parent 6bb1a72 commit 8ff5eb0

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

app/views/boards/edit/_publication.html.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
placeholder: "Add a public note about this board…",
3535
data: { action: "keydown.ctrl+enter->form#submit:prevent keydown.meta+enter->form#submit:prevent keydown.esc->form#cancel:stop" },
3636
readonly: !Current.user.can_administer_board?(@board) %>
37-
<%= form.button "Save changes", type: :submit, class: "btn txt-small" %>
37+
<%= form.button "Save changes", type: :submit, class: "btn txt-small", title: "Save changes (#{ hotkey_label(["ctrl", "enter"]) })" %>
3838
<% end %>
3939
</div>
4040
</div>

app/views/cards/comments/_new.html.erb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
<span class="flex-inline align-center gap">
1818
<%= form.button class: "comment__submit btn btn--reversed",
19+
title: "Post this comment (#{ hotkey_label(["ctrl", "enter"]) })",
1920
data: { form_target: "submit" }, disabled: true do %>
2021
<span>Post</span>
2122
<% end %>

app/views/cards/comments/edit.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
<%= general_prompts(@card.board) %>
1313
<% end %>
1414
<div class="flex gap-half justify-start align-center">
15-
<%= form.button class: "btn btn--reversed", type: :submit do %>
15+
<%= form.button class: "btn btn--reversed", type: :submit, title: "Save changes (#{ hotkey_label(["ctrl", "enter"]) })" do %>
1616
<span>Save</span>
1717
<% end %>
18-
<%= link_to card_comment_path(@card, @comment), class: "btn", data: { form_target: "cancel" } do %>
18+
<%= link_to card_comment_path(@card, @comment), class: "btn", data: { form_target: "cancel" },title: "Cancel (#{ hotkey_label(["esc"]) })" do %>
1919
<span>Cancel</span>
2020
<% end %>
2121

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div class="flex gap-half">
22
<%= button_tag type: :submit, form: dom_id(card, :edit_form), class: "btn borderless",
3+
title: "Save changes (#{ hotkey_label(["ctrl", "enter"]) })",
34
data: { controller: "hotkey", action: "keydown.ctrl+enter@document->hotkey#click keydown.meta+enter@document->hotkey#click" } do %>
45
<span>Save changes</span>
5-
<kbd class="txt-x-small hide-on-touch"><%= hotkey_label(["ctrl", "enter"]) %></kbd>
66
<% end %>
77
</div>
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
<div class="card-perma__notch card-perma__notch--bottom">
22
<%= button_to card_publish_path(card), name: "creation_type", value: "add", class: "btn",
3+
title: "Create card (#{ hotkey_label(["ctrl", "enter"]) })",
34
form: { data: { controller: "form" } },
45
data: { form_target: "submit", controller: "clicker", action: "keydown.ctrl+enter@document->clicker#click keydown.meta+enter@document->clicker#click" } do %>
56
<span>Create card</span>
67
<% end %>
78

89
<%= button_to card_publish_path(card), method: :post, class: "btn btn--reversed", name: "creation_type", value: "add_another",
9-
title: "Create and add another (ctrl+shift+enter)", form: { data: { controller: "form" } },
10+
title: "Create and add another (#{ hotkey_label(["ctrl", "shift", "enter"]) })", form: { data: { controller: "form" } },
1011
data: { form_target: "submit", controller: "clicker", action: "keydown.ctrl+shift+enter@document->clicker#click keydown.meta+shift+enter@document->clicker#click" } do %>
1112
<span>Create and add another</span>
12-
<kbd class="txt-x-small hide-on-touch"><%= hotkey_label([ "ctrl", "shift", "enter" ]) %></kbd>
1313
<% end %>
1414
</div>

0 commit comments

Comments
 (0)