Merge pull request #1936 from basecamp/use-self

jorgemanrubia · web-flow · commit fce6345fa6a4 · 2025-12-04T22:42:55.000+01:00
Use buil-in support for :self in Stimulus
diff --git a/app/javascript/controllers/bubble_controller.js b/app/javascript/controllers/bubble_controller.js
@@ -28,12 +28,6 @@ export default class extends Controller {
     }
   }
 
-  morphed({target}) {
-    if (this.element === target) {
-      this.update()
-    }
-  }
-
   get #hasEntropy() {
     return this.#entropyCleanupInDays < this.entropyValue.daysBeforeReminder
   }
diff --git a/app/views/cards/display/preview/_bubble.html.erb b/app/views/cards/display/preview/_bubble.html.erb
@@ -4,7 +4,7 @@
       class: "bubble",
       data: {
         controller: "bubble",
-        action: "turbo:morph-element->bubble#morphed",
+        action: "turbo:morph-element->bubble#update:self",
         bubble_entropy_value: entropy_bubble_options_for(card).to_json,
         bubble_stalled_value: stalled_bubble_options_for(card)&.to_json
       } do %>

Original file line number	Diff line number	Diff line change
`@@ -28,12 +28,6 @@ export default class extends Controller {`
`28`	`28`	`}`
`29`	`29`	`}`
`30`	`30`
`31`		`- morphed({target}) {`
`32`		`- if (this.element === target) {`
`33`		`- this.update()`
`34`		`- }`
`35`		`- }`
`36`		`-`
`37`	`31`	`get #hasEntropy() {`
`38`	`32`	`return this.#entropyCleanupInDays < this.entropyValue.daysBeforeReminder`
`39`	`33`	`}`