Merge pull request #2443 from basecamp/remove-zero-padding-from-account-slug

Remove zero-padding from account slug

Author: kevinmcconnell

config/initializers/tenanting/account_slug.rb

@@ -1,6 +1,5 @@
 module AccountSlug
-  PATTERN = /(\d{7,})/
-  FORMAT = "%07d"
+  PATTERN = /(\d+)/
   PATH_INFO_MATCH = /\A(\/#{AccountSlug::PATTERN})/
 
   class Extractor
@@ -40,7 +39,7 @@ def call(env)
   end
 
   def self.decode(slug) slug.to_i end
-  def self.encode(id) FORMAT % id end
+  def self.encode(id) id.to_s end
 end
 
 Rails.application.config.middleware.insert_after Rack::TempfileReaper, AccountSlug::Extractor

test/middleware/account_slug_extractor_test.rb

@@ -44,6 +44,15 @@ class AccountSlugExtractorTest < ActiveSupport::TestCase
     assert_nil captured.fetch(:current_account)
   end
 
+  test "encodes account IDs without zero-padding" do
+    assert_equal "1", AccountSlug.encode(1)
+  end
+
+  test "decodes both padded and non-padded slugs" do
+    assert_equal 123, AccountSlug.decode("123")
+    assert_equal 123, AccountSlug.decode("0000123")
+  end
+
   private
     def call_with_env(path, extra_env = {})
       captured = {}